Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Allows for custom headers to be sent, helpful for Authorization #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bennett000
Copy link

No description provided.

@bennett000
Copy link
Author

I am not certain why these errors are occurring. I was certainly responsible for some linter errors that I fixed but the other errors seem to be entirely around node code...

@sindresorhus
Copy link
Contributor

Needs a test and be documented.

@bennett000
Copy link
Author

bennett000 commented Feb 14, 2017

I can document this no problem. I have two challenges with testing:

  • The existing tests pass locally but CI is blowing up
  • I'm not sure how to go about testing the header code since the current test suite is setup for integration testing and ends up passing file:/// urls directly to phantom.

Ultimately I don't have strong opinions on this since we ended up going with a third part a11y testing service that uses humans.

@seanmwalker
Copy link

My apologies, I didn't see this PR. I did submit one last night that I think gives the same capabilities. That one allows for a phantomjs configuration file to be specified. Using that you can set headers etc... Let me know if that helps at all or if it's not the same issue. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants