Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development with master #81

Open
wants to merge 349 commits into
base: master
Choose a base branch
from
Open

Merge development with master #81

wants to merge 349 commits into from

Conversation

adesege
Copy link
Owner

@adesege adesege commented Jan 8, 2018

No description provided.

* add coveralls badge

* implement BFA feedback
* add coveralls badge

* implement BFA feedback

* add codeclimate badge. add dist files. update package.json

* update readme.md

* add test db

* add dist/ files

* update readme.md
* add coveralls badge

* implement BFA feedback

* add codeclimate badge. add dist files. update package.json

* update readme.md

* add test db

* add dist/ files

* update readme.md

* update route and middleware
* add coveralls badge

* implement BFA feedback

* add codeclimate badge. add dist files. update package.json

* update readme.md

* add test db

* add dist/ files

* update readme.md

* update route and middleware

* update sequelizerc (#25)
* add coveralls badge

* implement BFA feedback

* add codeclimate badge. add dist files. update package.json

* update readme.md

* add test db

* add dist/ files

* update readme.md

* update route and middleware

* update sequelizerc (#25)

* Implement bfa feedback merge (#27)

* update sequelizerc

* update index.js

* Update route index.js
adesege and others added 28 commits November 10, 2017 22:36
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke

* bug(make-test-pass): make test pass on travis

* feature(social-auth): add facebook and google social login

* bug(bug-fix): change the order of users migration files

* feat(reset-password): reset password on client side

* chore(server-test): refactor server test to separate folders

* chore(reactor-readme): implement LF feedback by refactoring readme file

* chore(server): refactor server side to use express-api-versioning to dynamically route between different api versions
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke

* bug(make-test-pass): make test pass on travis

* feature(social-auth): add facebook and google social login

* bug(bug-fix): change the order of users migration files

* feat(reset-password): reset password on client side

* chore(server-test): refactor server test to separate folders

* chore(reactor-readme): implement LF feedback by refactoring readme file

* chore(server): refactor server side to use express-api-versioning to dynamically route between different api versions

* chore(stabilize-base-application): stabilize base application for deployment on Heroku

- remove jquery dependency
- remove client build from VC
- add env.sample files to client and server applications
- rename folders to follow airbnb style guide
- make client app build on Heroku
- remove extraneous dependecies in client app
- add disqus for reviewing a book
- add webpack alias for eslint
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke

* bug(make-test-pass): make test pass on travis

* feature(social-auth): add facebook and google social login

* bug(bug-fix): change the order of users migration files

* feat(reset-password): reset password on client side

* chore(server-test): refactor server test to separate folders

* chore(client-validation): add client side validation to sigin, signup and add category forms
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke

* bug(make-test-pass): make test pass on travis

* feature(social-auth): add facebook and google social login

* bug(bug-fix): change the order of users migration files

* feat(reset-password): reset password on client side

* chore(server-test): refactor server test to separate folders

* chore(client-validation): add client side validation to sigin, signup and add category forms

* bug(bug-fix): fix bug that doesn't allow users add a book in production
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke

* bug(make-test-pass): make test pass on travis

* feature(social-auth): add facebook and google social login

* bug(bug-fix): change the order of users migration files

* feat(reset-password): reset password on client side

* chore(server-test): refactor server test to separate folders

* chore(client-validation): add client side validation to sigin, signup and add category forms

* bug(bug-fix): fix bug that doesn't allow users add a book in production

* bug(bug-fix): refactor error handling when book can't be added

- add page loader
- remove documentPath from book validation
- remove extraneous dependencies in client
- rename server controller and model file naming convention
- rewrite the way errors are sent in server
- test actual values in server test
- fix user should be able to change password feeature
- refactor readme documentation
- remove multiple eslint config files
- fix restart dyno issues in production
- add JSDOC documentation to server and client side code
- change `data` variable name
- add error boundary to resolve component errors in production
- account for potential errors by adding catch callbacks to some model calls
- change error messages to be more descriptive
- use approprite status code in user controller
- fix uneven background height on different viewport
@@ -0,0 +1,59 @@
import models from '../../models';
import { user, admin } from './user';
import utils from '../../utils';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../utils' import/no-unresolved
Missing file extension for "../../utils" import/extensions

@@ -0,0 +1,59 @@
import models from '../../models';
import { user, admin } from './user';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module './user' import/no-unresolved
Missing file extension for "./user" import/extensions

@@ -0,0 +1,59 @@
import models from '../../models';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../models' import/no-unresolved
Missing file extension for "../../models" import/extensions

import supertest from 'supertest';
import app from '../../../../express';
import { user } from '../seeds/user';
import { generateToken } from '../seeds';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../seeds' import/no-unresolved
Missing file extension for "../seeds" import/extensions

import chai from 'chai';
import supertest from 'supertest';
import app from '../../../../express';
import { user } from '../seeds/user';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../seeds/user' import/no-unresolved
Missing file extension for "../seeds/user" import/extensions

}

if (type === "signup" ||
type === "change-password" ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

}
}

if (type === "signup" ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

if (type === "signup" ||
type === "login" ||
type === "change-password" ||
type === "change-password-user") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes


if (type === "signup" ||
type === "login" ||
type === "change-password" ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

}

if (type === "signup" ||
type === "login" ||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings must use singlequote quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants