Merge pull request #25 from adidas/feature/update-typescript-plugin

UPDATE eslint-typescript plugin config
adidas · Dec 4, 2019 · b0cd539 · b0cd539
2 parents 02e58fb + 87eab36
commit b0cd539
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ This changelog is only to log changes of the project base.
 If there are changes on the packages, please, check and update the changelog of each package accordingly.
 -->
 
+## 1.7.1
+
+- Updated `eslint-config-adidas-typescript` dependencies and rules.
+
 # 1.7.0
 
 - Updated eslint to v6.

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "js-linter-configs",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "description": "adidas configurations for JavaScript linting tools",
   "license": "MIT",
   "contributors": [

diff --git a/packages/eslint-config-adidas-typescript/CHANGELOG.md b/packages/eslint-config-adidas-typescript/CHANGELOG.md
@@ -1,3 +1,16 @@
+# 1.3.0
+
+- Updated `@typescript-eslint/parser` and `@typescript-eslint/eslint-plugin` to v2.9.0.
+- Added rules:
+    - `@typescript-eslint/no-dynamic-delete`
+    - `@typescript-eslint/no-extra-non-null-assertion`
+    - `@typescript-eslint/no-untyped-public-signature`
+    - `@typescript-elsint/prefer-nullish-coalescing`
+    - `@typescript-elsint/prefer-optional-chain`
+    - `@typescript-elsint/restrict-template-expressions`
+    - `@typescript-elsint/return-await`
+    - `@typescript-elsint/space-before-function-paren`
+
 # 1.2.0
 
 - Updated ESLint to version 6.

diff --git a/packages/eslint-config-adidas-typescript/index.js b/packages/eslint-config-adidas-typescript/index.js
@@ -21,6 +21,7 @@ module.exports = {
     'no-use-before-define': 'off',
     'no-useless-constructor': 'off',
     'semi': 'off',
+    'space-before-function-paren': 'off',
     '@typescript-eslint/adjacent-overload-signatures': 'error',
     '@typescript-eslint/array-type': [ 'error', { readonly: 'generic', default: 'generic' }],
     '@typescript-eslint/await-thenable': 'error',
@@ -157,9 +158,11 @@ module.exports = {
       }
     ],
     '@typescript-eslint/no-array-constructor': 'error',
+    '@typescript-eslint/no-dynamic-delete': 'off',
     '@typescript-eslint/no-empty-function': 'off',
     '@typescript-eslint/no-empty-interface': 'error',
     '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-extra-non-null-assertion': 'error',
     '@typescript-eslint/no-extra-parens': [
       'error',
       'all',
@@ -207,6 +210,7 @@ module.exports = {
     '@typescript-eslint/no-type-alias': 'off',
     '@typescript-eslint/no-unnecessary-qualifier': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+    '@typecsript-eslint/no-untyped-public-signature': 'error',
     '@typescript-eslint/no-unused-vars': [
       'error',
       {
@@ -231,6 +235,8 @@ module.exports = {
     '@typescript-eslint/prefer-function-type': 'off',
     '@typescript-eslint/prefer-includes': 'error',
     '@typescript-eslint/prefer-namespace-keyword': 'error',
+    '@typescript-eslint/prefer-nullish-coalescing': 'error',
+    '@typescript-eslint/prefer-optional-chain': 'error',
     '@typescript-eslint/prefer-readonly': [
       'error',
       {
@@ -252,7 +258,16 @@ module.exports = {
     ],
     '@typescript-eslint/require-array-sort-compare': 'error',
     '@typescript-eslint/restrict-plus-operands': 'error',
+    '@typescript-eslint/restrict-template-expressions': 'off',
+    '@typescript-eslint/return-await': [ 'error', 'in-try-catch' ],
     '@typescript-eslint/semi': [ 'error', 'always' ],
+    '@typescript-eslint/space-before-function-paren': [
+      'error', {
+        anonymous: 'never',
+        named: 'never',
+        asyncArrow: 'always'
+      }
+    ],
     '@typescript-eslint/strict-boolean-expressions': 'off',
     '@typescript-eslint/triple-slash-reference': 'error',
     '@typescript-eslint/type-annotation-spacing': [

diff --git a/packages/eslint-config-adidas-typescript/package.json b/packages/eslint-config-adidas-typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-adidas-typescript",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "ESLint base configuration and rules for TypeScript codebases",
   "license": "MIT",
   "contributors": [
@@ -17,8 +17,8 @@
   },
   "main": "./index.js",
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.4",
-    "@typescript-eslint/parser": "^2.4",
+    "@typescript-eslint/eslint-plugin": "^2.9",
+    "@typescript-eslint/parser": "^2.9",
     "eslint-config-adidas-es9": "^1.2"
   },
   "peerDependencies": {