Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0 #61

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ This changelog is only to log changes of the project base.
If there are changes on the packages, please, check and update the changelog of each package accordingly.
-->

## 3.1.0

- Replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0.

# 3.0.0

- Updated engine requirements to node 18 and npm 9.
Expand Down
119 changes: 68 additions & 51 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "js-linter-configs",
"version": "3.0.0",
"version": "3.1.0",
"description": "adidas configurations for JavaScript linting tools",
"license": "MIT",
"contributors": [
Expand All @@ -15,15 +15,17 @@
"node": ">= 18",
"npm": ">= 9"
},
"workspaces": [ "packages/*" ],
"workspaces": [
"packages/*"
],
"scripts": {
"safe-publish": "npm exec --workspaces -- safe-publish",
"lint": "eslint packages"
},
"devDependencies": {
"chalk": "5.3.0",
"eslint": "8.50.0",
"eslint-plugin-node": "11.1.0",
"eslint-plugin-n": "14.0.0",
"safe-publish": "1.2.1"
},
"keywords": [
Expand Down
4 changes: 4 additions & 0 deletions packages/eslint-config-adidas-env/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.1.0

- Replace dependency eslint-plugin-node with eslint-plugin-n 14.0.0.

## 2.0.0

- Updated ESLint to version 8.
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-adidas-env/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Environment configurations for ESLint:
## Install

```
npm i --save-dev eslint@8 eslint-plugin-node@11 eslint-config-adidas-env
npm i --save-dev eslint@8 eslint-plugin-n@14 eslint-config-adidas-env
```

## Usage
Expand Down
14 changes: 7 additions & 7 deletions packages/eslint-config-adidas-env/module.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
module.exports = {
plugins: [ 'node' ],
plugins: [ 'n' ],
env: {
commonjs: true
},
parserOptions: {
sourceType: 'module'
},
rules: {
'node/global-require': 'off',
'node/no-mixed-requires': 'off',
'node/no-new-require': 'error',
'node/no-process-env': 'off',
'node/no-process-exit': 'off',
'node/no-restricted-modules': 'off'
'n/global-require': 'off',
'n/no-mixed-requires': 'off',
'n/no-new-require': 'error',
'n/no-process-env': 'off',
'n/no-process-exit': 'off',
'n/no-restricted-modules': 'off'
}
};
8 changes: 4 additions & 4 deletions packages/eslint-config-adidas-env/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ module.exports = {
rules: {
'no-buffer-constructor': 'error',

'node/callback-return': 'off',
'node/handle-callback-err': 'error',
'node/no-path-concat': 'error',
'node/no-sync': 'off'
'n/callback-return': 'off',
'n/handle-callback-err': 'error',
'n/no-path-concat': 'error',
'n/no-sync': 'off'
}
};
4 changes: 2 additions & 2 deletions packages/eslint-config-adidas-env/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-adidas-env",
"version": "2.0.0",
"version": "2.1.0",
"description": "ESLint configurations for multiple environments",
"license": "MIT",
"contributors": [
Expand All @@ -18,7 +18,7 @@
"main": "./browser.js",
"peerDependencies": {
"eslint": "^8",
"eslint-plugin-node": "^11"
"eslint-plugin-n": "^14"
},
"files": [
"browser.js",
Expand Down
Loading