Open
Conversation
it would cause issue with linting, because it would "cancel" the command for linting instead of letting it return the parse errors linting is much smoother now
because of an error without this, emacs would wait indefinitly for the command to return something
it was moved (and split) into tests/pattern/
- add new patterns for matching against standard objects: slot-pattern and object-pattern - pattern iterator can now be walked with next-preorder - :either patterns can be named - add function "extract-names" that gather all the meta-variables in a pattern (recursively) - add function "let-match" to easily bind meta-variables to actual variables - remove with-match-let - fix match named repetition against input that is donep, retun a binding object, not just t - fix typo substition => substitution - WIP add function "top-level-forms" to handle forms that preserves the "top-level-ness" - fix add-binding: add missing methods to handle t and nil correctly - refactor.lisp: extract "other files", "header-line" and "quickload" - move bunch of files under new module "src/cmds"
way too many if you ask me
quicklisp must be install for the documentation to be generated correctly, another fix _could_ have been to find a way to define the "quickload" command without requiring quicklisp to be available (asdf:test-system 'breeze) was using the wrong function ~run-breeze-tests~ that was previously renamed to ~run-all-tests~
technically not tested™
for example, by using M-x load-file instead of running the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'M NOT ANGRY AT Y'ALL
IT IS MY ISRAELI HABIT
CAPS LOCK ENGLISH KEYS