Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #2391 - Add the option to use i18n labels for content fragment element titles #2493

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

royteeuwen
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #1, Fixes #2391
Patch: Bug Fix?
Minor: New Feature? Yes
Major: Breaking Change?
Tests Added + Pass? Not applicable? no UI tests in AEM core components
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Add the option to use i18n labels for content fragment element titles, which are not translateable in any UI of AEM

…ragment element titles, which are not translateable in any UI of AEM
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.26%. Comparing base (f28f5fd) to head (a8a7975).

Files Patch % Lines
...models/v1/contentfragment/ContentFragmentImpl.java 0.00% 1 Missing ⚠️
...ls/v1/contentfragment/ContentFragmentListImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2493      +/-   ##
============================================
- Coverage     87.28%   87.26%   -0.03%     
- Complexity     2659     2661       +2     
============================================
  Files           232      232              
  Lines          7110     7114       +4     
  Branches       1084     1084              
============================================
+ Hits           6206     6208       +2     
- Misses          359      361       +2     
  Partials        545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Fragment not translateable Empty placeholder should display component's title
2 participants