Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2588] Fix aria-controls label for tabs component #2509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rubnig
Copy link

@rubnig rubnig commented May 23, 2023

Fixes #2508

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (f28f5fd) to head (57ab892).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2509   +/-   ##
=========================================
  Coverage     87.28%   87.28%           
  Complexity     2659     2659           
=========================================
  Files           232      232           
  Lines          7110     7110           
  Branches       1084     1084           
=========================================
  Hits           6206     6206           
  Misses          359      359           
  Partials        545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@HitmanInWis
Copy link

Looking at https://github.com/adobe/aem-core-wcm-components/blob/main/content/src/content/jcr_root/apps/core/wcm/components/tabs/v1/tabs/tabs.html it seems this fix has already been implemented. I'm not sure why the diff for the patch still shows a diff to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] Broken aria-controls HTML attribute for tabs
3 participants