-
Notifications
You must be signed in to change notification settings - Fork 4
feat: drop support for personal onedrive folders #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 55 55
Lines 2392 2395 +3
=======================================
+ Hits 2391 2394 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const { pathname } = new URL(url); | ||
| return pathname.toLowerCase().endsWith('/onedrive.aspx') | ||
| || [ | ||
| '/personal/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add /my too no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect it to not open on this folder as well.
Fix #527