Conversation
Adds getSheetByName util that resolves a named sheet from both single-sheet (via :sheetname) and multi-sheet (via named key) config JSON. Fixes fetchLibraryConfig which previously assumed multi-sheet only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kptdobe
requested review from
auniverseaway and
chrischrischris
and removed request for
auniverseaway
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chrischrischris
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Customer reported issue: library (blocks, templates, icons...) is not loaded if the repo config has only one "library" sheet.
Summary
getSheetByName(json, name)utility toblocks/shared/utils.jsthat resolves a named sheet from both single-sheet configs (validated via':sheetname') and multi-sheet configs (via named key)fetchLibraryConfiginda-library/helpers/helpers.jswhich previously destructuredlibrarydirectly from the config, breaking when the config is a single-sheet fileconfigs[1])Test plan
getSheetByNameunit tests covering: multi-sheet hit, multi-sheet miss, single-sheet name match, single-sheet name mismatch, single-sheet no:sheetname, single-sheet nodataTest page: https://sheetfix--da-live--adobe.aem.live/edit#/doe-app-svc/da-sws-tester2/index
🤖 Generated with Claude Code