Conversation
When a <p> containing multiple <img> tags was the sole child of its parent, makePictures replaced the entire <p> with only the first image's <picture>, orphaning the rest. Adding childElementCount === 1 guard on the <p> ensures the unwrap only fires for single-image cells. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
chrischrischris
approved these changes
May 8, 2026
auniverseaway
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Customer reported only first image of each column in a
columnblock with a lot of images in each column are not visible in the preview box.See:
Before: https://main--da-live--adobe.aem.live/edit#/kptdobe/daplayground/images
After: https://multiimg--da-live--adobe.aem.live/edit#/kptdobe/daplayground/images
Just open the preview window.
Summary
makePicturesinprose2aem.jswas replacing the entire<p>element with the first image's<picture>whenever the<p>was the sole child of its grandparent — even when that<p>contained multiple<img>tagsimgParent.childElementCount === 1guard so the<p>-unwrap only fires when the<p>holds exactly one imageTest plan
Preserves all images in each column when a column block has 3 columns with multiple images per columnprose2aemtests continue to pass (no regressions)npm test— 1314 passed, 0 failed🤖 Generated with Claude Code