Skip to content

Conversation

Mr-Heidari
Copy link
Contributor

Closes #8809

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@Mr-Heidari Mr-Heidari closed this Sep 4, 2025
@Mr-Heidari Mr-Heidari reopened this Sep 4, 2025
@Mr-Heidari
Copy link
Contributor Author

Hello, I've added the isReadOnly property . in this issue #6151 I've also seen some other components where we can apply the props that were discussed. If you approve, I can fix those as well.

@Mr-Heidari Mr-Heidari changed the title add isReadOnly props and useRenderProps fix: add isReadOnly props and useRenderProps Sep 4, 2025
@LFDanLu
Copy link
Member

LFDanLu commented Sep 4, 2025

@Mr-Heidari that would be amazing, thanks! As shown in #6151 I think making sure the components that support the isReadOnly prop have the equivalent in their renderProps/data-attributes will be sufficient for now.

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! i'd like to get this in so if you'd like to add isReadOnly to the other components, we can do that in a separate PR

@LFDanLu LFDanLu added this pull request to the merge queue Sep 8, 2025
Merged via the queue into adobe:main with commit 1c07381 Sep 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker isReadOnly does not apply data-readonly attribute to the react-aria-DatePicker
3 participants