fix(useViewportSize): update size after hydration #8966
+31
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
In the
useViewportSize
hook, nothing is updating thesize
state after hydration is run. This was causinguseViewport
size to get stuck on0x0
until the window is resized, just like in the screen recording below:fix-use-viewport.mp4
After
The
onResize
function is run within theuseEffect
just as theresize
listener is attached. I have written a test that fails without this call.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: