docs: Add examples section #9094
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Oct 24, 2025
| let press = pressScale(domRef, UNSAFE_style); | ||
| if (ElementType === 'div' && !isSkeleton && props.href) { | ||
| // Standalone Card that has an href should be rendered as a Link. | ||
| // NOTE: In this case, the card must not contain interactive elements. |
There was a problem hiding this comment.
We don't really have a way to enforce this...
devongovett
commented
Oct 24, 2025
| let estimatedSize = true; | ||
| if (oldLayoutInfo) { | ||
| height = oldLayoutInfo.rect.height; | ||
| height = oldLayoutInfo.rect.height / oldLayoutInfo.rect.width * itemWidth; |
There was a problem hiding this comment.
If the card size changes (e.g. user drags slider in photo library example), re-calculate the height proportionally.
devongovett
commented
Oct 24, 2025
| // Figure out which column to place the item in, and compute its position. | ||
| // Preserve the previous column index so items don't jump around during resizing unless the number of columns changed. | ||
| let prevColumn = numColumns === this.numColumns && oldLayoutInfo && oldLayoutInfo.rect.y < this.virtualizer!.visibleRect.maxY ? oldLayoutInfo.column : undefined; | ||
| let prevColumn = numColumns === this.numColumns && oldLayoutInfo && oldLayoutInfo.index === index && oldLayoutInfo.rect.y < this.virtualizer!.visibleRect.maxY ? oldLayoutInfo.column : undefined; |
There was a problem hiding this comment.
Don't preserve the column if the index within the collection changed. When filtering the photo library, the cards were staying where they were previously, resulting in "holes" appearing. We want to re-flow in this case.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds examples section to new RAC docs. Ports over a few examples from the old docs, and adds a few new ones.
A few other bug fixes are included:
size()macro to returncalcdirectly without wrapping in square brackets, enabling it to be interpolated into CSS strings.font-variation-settingsfrom the Spectrum macro theme now that the Typekit issue has been fixed for a while. This was causing incorrect fonts to display in Tailwind and Vanilla CSS examples which were not overriding it.href. Such cards must not have interactive elements within them.