fix: render menu popover if menu trigger is inside popover

[yihuiliao]

Original issue: RSP Component Milestones (view)

• Menu does not render a popover if it is already in one (intended for menus to support sibling elements). But we should reset this context in MenuTrigger.

Link to chromatic: https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1104

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the S2 storybook, go to Popover and look for the MenuTrigger story, open the popover and click on the "..." button which should display the menu in a separate popover

🧢 Your Project:

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the S2 docs
• View the React Aria docs

[snowystinger]

Just checking, does this also work with a menu inside a parent menu's subdialog?

[yihuiliao]

Just checking, does this also work with a menu inside a parent menu's subdialog?

hmm not sure, i'll have to check

edit: i think it should be fine (i tried it locally). i'm assuming what you're talking about is something like this:

<MenuTrigger>
  <Button />
  <Menu>
    <MenuItem />
    <MenuItem />
    <SubmenuTrigger>
       <MenuItem />
       <Popover> 
          // the subdialog stuff
          <Menu>
            <MenuItem />
          </Menu>
       </Popover>
    </SubmenuTrigger>
  </Menu>
</MenuTrigger>

but if someone is rendering a subdialog, that means they're rendering a popover. so in that case, inPopover is set to true. if a menu is rendered inside of that dialog, then it won't try to recreate the popover. if an action menu is rendered inside of that dialog with a trigger, the menutrigger will overwrite the inPopover context to false and the menu will be rendered with a popover.