fix: catch error within customerIntent endpoints #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return status code instead of throwing the whole handler
|
This PR will trigger a patch release when merged. |
calvarezg
approved these changes
Sep 5, 2025
|
@JayKid |
ravverma
requested changes
Sep 8, 2025
| const { llmoConfig } = await getSiteAndValidateLlmo(context); | ||
| return ok(llmoConfig.customerIntent || []); | ||
| try { | ||
| const { llmoConfig } = await getSiteAndValidateLlmo(context); |
There was a problem hiding this comment.
handle it in getSiteAndValidateLlmo method itself rather everyplace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return status code instead of throwing the whole handler
The PR basically wraps the CRUD
customerIntentendpoints in a try catch and returns appropriate status codes instead of allowing thehasAccessfunction throwing an error to crash the handler.Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
Related Issues