Skip to content

fix: updating lorem-ipsum check name in preflight #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

fix: updating lorem-ipsum check name in preflight #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bdc943
fix: updating lorem-ipsum check name in preflight
Sep 9, 2025
e5596be
fix: reverting to latest deployment
Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/openapi/preflight-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ preflight-jobs:
type: array
items:
type: string
enum: [canonical, links, metatags, body-size, lorem-ipsum, h1-count, readability, accessibility]
enum: [canonical, links, metatags, body-size, 'placeholder "lorem-ipsum" detection', h1-count, readability, accessibility]
description: Optional array of specific checks to run. If not provided, all checks will be run.
required:
- urls
Expand Down
2 changes: 1 addition & 1 deletion src/controllers/preflight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const AUDIT_CANONICAL = 'canonical';
export const AUDIT_LINKS = 'links';
export const AUDIT_METATAGS = 'metatags';
export const AUDIT_BODY_SIZE = 'body-size';
export const AUDIT_LOREM_IPSUM = 'lorem-ipsum';
export const AUDIT_LOREM_IPSUM = 'placeholder "lorem-ipsum" detection';
export const AUDIT_H1_COUNT = 'h1-count';
export const AUDIT_ACCESSIBILITY = 'accessibility';
export const AUDIT_READABILITY = 'readability';
Expand Down
8 changes: 4 additions & 4 deletions test/controllers/preflight.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ describe('Preflight Controller', () => {
urls: ['https://main--example-site.aem.page/test.html'],
step: 'identify',
enableAuthentication: true,
checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'],
checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'],
},
jobType: 'preflight',
tags: ['preflight'],
Expand Down Expand Up @@ -218,7 +218,7 @@ describe('Preflight Controller', () => {
urls: ['https://main--example-site.aem.page/test.html'],
step: 'identify',
enableAuthentication: false,
checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'],
checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'],
},
jobType: 'preflight',
tags: ['preflight'],
Expand Down Expand Up @@ -295,7 +295,7 @@ describe('Preflight Controller', () => {

const result = await response.json();
expect(result).to.deep.equal({
message: 'Invalid request: checks must be one of: canonical, links, metatags, body-size, lorem-ipsum, h1-count, accessibility, readability',
message: 'Invalid request: checks must be one of: canonical, links, metatags, body-size, placeholder "lorem-ipsum" detection, h1-count, accessibility, readability',
});
});

Expand Down Expand Up @@ -353,7 +353,7 @@ describe('Preflight Controller', () => {
urls: ['https://main--example-site.aem.page/test.html'],
step: 'identify',
enableAuthentication: true,
checks: ['canonical', 'links', 'metatags', 'body-size', 'lorem-ipsum', 'h1-count', 'accessibility', 'readability'],
checks: ['canonical', 'links', 'metatags', 'body-size', 'placeholder "lorem-ipsum" detection', 'h1-count', 'accessibility', 'readability'],
},
jobType: 'preflight',
tags: ['preflight'],
Expand Down