Skip to content

feat: top paid opportunites v2 #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mimchome wants to merge 10 commits into
base: main
Choose a base branch
from
+2,183 −668
Draft

feat: top paid opportunites v2 #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1adaa64
working v2
mimchome Dec 16, 2025
1577329
increase coverage
mimchome Dec 17, 2025
9daedcf
increase branch cov
mimchome Dec 17, 2025
26d2456
increase branch cov
mimchome Dec 17, 2025
3e8b5a6
increase branch cov
mimchome Dec 17, 2025
cb0f15d
coverage
mimchome Dec 17, 2025
46e1cdb
improve test
mimchome Dec 17, 2025
19fb825
return sorted urls by views
mimchome Dec 17, 2025
ed4d5ab
only slice at end
mimchome Dec 17, 2025
962878e
use new suggestions
mimchome Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 1 addition & 61 deletions src/controllers/opportunities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import {
} from '@adobe/spacecat-shared-utils';
import { ValidationError } from '@adobe/spacecat-shared-data-access';
import { OpportunityDto } from '../dto/opportunity.js';
import { OpportunitySummaryDto } from '../dto/opportunity-summary.js';
import AccessControlUtil from '../support/access-control-util.js';

/**
Expand All @@ -44,7 +43,7 @@ function OpportunitiesController(ctx) {
if (!isNonEmptyObject(dataAccess)) {
throw new Error('Data access required');
}
const { Opportunity, Suggestion } = dataAccess;
const { Opportunity } = dataAccess;
if (!isObject(Opportunity)) {
throw new Error('Opportunity Collection not available');
}
Expand Down Expand Up @@ -312,70 +311,11 @@ function OpportunitiesController(ctx) {
}
};

/**
* Gets top opportunities for paid media with 'NEW' or 'IN_PROGRESS' status for a site.
* @param {Object} context of the request
* @returns {Promise<Response>} Array of opportunity summaries.
*/
const getTopPaidOpportunities = async (context) => {
const siteId = context.params?.siteId;

if (!isValidUUID(siteId)) {
return badRequest('Site ID required');
}

const site = await Site.findById(siteId);
if (!site) {
return notFound('Site not found');
}
if (!await accessControlUtil.hasAccess(site)) {
return forbidden('Only users belonging to the organization of the site can view its opportunities');
}

const newOpportunities = await Opportunity.allBySiteIdAndStatus(siteId, 'NEW');
const inProgressOpportunities = await Opportunity.allBySiteIdAndStatus(siteId, 'IN_PROGRESS');
const allOpportunities = [...newOpportunities, ...inProgressOpportunities];

// temp using all these tags for testing but evenutally we will just use 'paid media'
const targetTags = ['paid media', 'traffic acquisition', 'engagement', 'content optimization'];
const filteredOpportunities = allOpportunities.filter((oppty) => {
const tags = oppty.getTags() || [];
const title = oppty.getTitle() || '';
const description = oppty.getDescription();

if (!description) {
return false;
}

if (title.toLowerCase().includes('report')) {
return false;
}

return tags.some((tag) => targetTags.includes(tag.toLowerCase()));
});

const opportunitySummaries = await Promise.all(
filteredOpportunities.map(async (oppty) => {
const suggestions = await Suggestion.allByOpportunityId(oppty.getId());
return OpportunitySummaryDto.toJSON(oppty, suggestions);
}),
);

const validSummaries = opportunitySummaries.filter(
(summary) => summary.projectedTrafficValue > 0,
);

validSummaries.sort((a, b) => b.projectedTrafficValue - a.projectedTrafficValue);

return ok(validSummaries);
};

return {
createOpportunity,
getAllForSite,
getByID,
getByStatus,
getTopPaidOpportunities,
patchOpportunity,
removeOpportunity,
};
Expand Down
Loading