Skip to content

[test] full update for css packages (not for merging) #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Mar 27, 2025

This is a utility pull request that serves as a view of all remaining Spectrum CSS version updates remaining to be evaluated before the cutover.

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 70a7fa8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Mar 27, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from 61c5eb9 to 1cf61a3 Compare March 27, 2025 21:59
Copy link

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2025

Pull Request Test Coverage Report for Build 14135005473

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.009%

Totals Coverage Status
Change from base Build 14134663351: 0.007%
Covered Lines: 33713
Relevant Lines: 34211

💛 - Coveralls

@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from 1cf61a3 to 8128926 Compare March 27, 2025 22:13
@Rajdeepc
Copy link
Contributor

I am a little concerned with such a big list of file changes! Once you are ready let's discuss before we merge this in.

@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from 8128926 to 92b6077 Compare March 28, 2025 17:57
@castastrophe
Copy link
Collaborator Author

@Rajdeepc this isn't for merging - it's a preview of the full scope of changes if all packages were updated. That's why it's in draft. Are there other labels that will help clarify this?

@castastrophe castastrophe changed the title fix: full update for css packages [test] full update for css packages (not for merging) Mar 28, 2025
@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from 92b6077 to c7651d8 Compare March 28, 2025 21:10
@Rajdeepc
Copy link
Contributor

@Rajdeepc this isn't for merging - it's a preview of the full scope of changes if all packages were updated. That's why it's in draft. Are there other labels that will help clarify this?

That's okay! But let's discuss this with Josh and others before we decide to work on this.

@castastrophe
Copy link
Collaborator Author

That's okay! But let's discuss this with Josh and others before we decide to work on this.

@Rajdeepc It's already in the sprint. Like I said, don't worry about it. It's in draft and specifically says it's just a test.

@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch 15 times, most recently from 74ddbd9 to a6aa713 Compare April 4, 2025 15:54
@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch 4 times, most recently from db37bd6 to 18acae3 Compare April 10, 2025 23:04
@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch 8 times, most recently from ef168fe to acd07a6 Compare April 23, 2025 17:31
@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from acd07a6 to 1751763 Compare April 24, 2025 20:26
@castastrophe castastrophe force-pushed the castastrophe/full-css-update branch from 1751763 to 70a7fa8 Compare April 25, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants