-
Notifications
You must be signed in to change notification settings - Fork 218
chore: added story to demonstrate a delayed tooltip example #5384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 29732fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChrometooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
Firefoxtooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the image has so that all tests pass.
Can you add a changeset for the tooltip package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
This PR adds a new story to the Tooltip component documentation that demonstrates how to properly handle interactions between delayed tooltips and other overlays.
Related issue(s)
Motivation and context
When a delayed tooltip appears while another overlay (like a popover or menu) is already open, the default DOM event bubbling can cause the existing overlay to close prematurely during the tooltip's warmup phase. This results in a poor user experience where:
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.