chore: testing overlay fixes #5625

rubencarvalho · 2025-07-22T09:55:56Z

Description

Motivation and context

Related issue(s)

fixes [Issue Number]

Screenshots (if appropriate)

Author's checklist

I have read the CONTRIBUTING and PULL_REQUESTS documents.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.

Reviewer's checklist

Includes a Github Issue with appropriate flag or Jira ticket number without a link
Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
Automated tests cover all use cases and follow best practices for writing
Validated on all supported browsers
All VRTs are approved before the author can update Golden Hash

Manual review test cases

Descriptive Test Statement
1. Go here
2. Do this action
3. Expect this result
Descriptive Test Statement
1. Go here
2. Do this action
3. Expect this result

Device review

Did it pass in Desktop?
Did it pass in (emulated) Mobile?
Did it pass in (emulated) iPad?

changeset-bot · 2025-07-22T09:55:59Z

⚠️ No Changeset found

Latest commit: 07569c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-07-22T09:57:40Z

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5625

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions · 2025-07-22T10:00:29Z

Tachometer results

Currently, no packages are changed by this PR...

…nteraction with the page

github-actions · 2025-07-23T12:18:00Z

packages/overlay/package.json

@@ -171,6 +171,7 @@
        "@spectrum-web-components/reactive-controllers": "1.7.0",
        "@spectrum-web-components/shared": "1.7.0",
        "@spectrum-web-components/theme": "1.7.0",
+        "@spectrum-web-components/underlay": "1.7.0",
        "focus-trap": "^7.6.4"
    },
    "types": "./src/index.d.ts",


⚠️ [eslint] <jsonc/sort-keys> _{reported by reviewdog 🐶}
Expected object keys to be in specified order. 'types' should be before 'dependencies'.

reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L177-L177 v.s. L153-L177

github-actions · 2025-07-24T09:42:47Z

packages/overlay/stories/overlay.stories.ts

+    return fragment.children[0] as HTMLElement;
+};
+
+const openModalOverlay = async (event: Event) => {


⚠️ [eslint] <@typescript-eslint/explicit-function-return-type> _{reported by reviewdog 🐶}
Missing return type on function.

github-actions · 2025-07-24T09:42:47Z

packages/overlay/stories/overlay.stories.ts

+    container?.insertAdjacentElement('afterend', overlay);
+};
+
+const openAutoOverlay = async (event: Event) => {


⚠️ [eslint] <@typescript-eslint/explicit-function-return-type> _{reported by reviewdog 🐶}
Missing return type on function.

rubencarvalho · 2025-07-28T11:04:12Z

packages/overlay/src/Overlay.ts

-            if (this.type === 'modal' || this.type === 'page') {
+            if (
+                (this.type === 'modal' || this.type === 'page') &&
+                this.receivesFocus !== 'false'


Move this condition to the initialFocus instead, because we want to have focus trap anyway

rubencarvalho · 2025-07-28T11:07:54Z

packages/overlay/src/Overlay.ts

@@ -431,10 +432,8 @@ export class Overlay extends ComputedOverlayBase {

        switch (this.type) {
            case 'modal':
-                return 'auto';
-            case 'page':
                return 'manual';


this changed, but github diff doesn't show it

rubencarvalho · 2025-07-28T11:09:22Z

packages/overlay/src/OverlayStack.ts

@@ -213,11 +237,29 @@ class OverlayStack {
                    const path = event.composedPath();
                    this.stack.forEach((overlayEl) => {
                        const inPath = path.find((el) => el === overlayEl);
+
+                        // Check if the trigger element is inside this overlay


dubious if needed

rubencarvalho · 2025-07-28T11:10:29Z

packages/overlay/src/Overlay.ts

                return 'manual';
-            case 'hint':


I changed hint to be hint, because why not?

maybe we can't do this because previously multiple hints could be open by using hint it closes the previous open hint

chore: testing overlay fixes

dd0c119

rubencarvalho added 5 commits July 22, 2025 11:27

chore: allow outside click

e87567c

chore: make hint overlays render hint popovers

87868a8

chore: make focustrap respect receivesFocus

74c9065

chore: conditionally render underlay when overlay is modal to block i…

b6dd797

…nteraction with the page

chore: also add underlay for page

fd7dd4b

github-actions bot reviewed Jul 23, 2025

View reviewed changes

rubencarvalho added 2 commits July 23, 2025 21:55

chore: manage body scroll blocking for modal and page overlays

d8eaafa

chore: use underlay inside a popover to render it in the top layer

07569c5

github-actions bot reviewed Jul 24, 2025

View reviewed changes

rubencarvalho commented Jul 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: testing overlay fixes #5625

chore: testing overlay fixes #5625

rubencarvalho commented Jul 22, 2025

Uh oh!

changeset-bot bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot Jul 23, 2025

Uh oh!

github-actions bot Jul 24, 2025

Uh oh!

github-actions bot Jul 24, 2025

Uh oh!

rubencarvalho Jul 28, 2025

Uh oh!

rubencarvalho Jul 28, 2025 •

edited

Loading

Uh oh!

rubencarvalho Jul 28, 2025

Uh oh!

rubencarvalho Jul 28, 2025

Uh oh!

rubencarvalho Jul 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

chore: testing overlay fixes #5625

Are you sure you want to change the base?

chore: testing overlay fixes #5625

Conversation

rubencarvalho commented Jul 22, 2025

Description

Motivation and context

Related issue(s)

Screenshots (if appropriate)

Author's checklist

Reviewer's checklist

Manual review test cases

Device review

Uh oh!

changeset-bot bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Branch Preview

🔍 Visual Regression Test Results

Uh oh!

github-actions bot commented Jul 22, 2025

Tachometer results

Uh oh!

github-actions bot Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

rubencarvalho Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

rubencarvalho Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubencarvalho Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

rubencarvalho Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

rubencarvalho Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Jul 22, 2025 •

edited

Loading

github-actions bot commented Jul 22, 2025 •

edited

Loading

rubencarvalho Jul 28, 2025 •

edited

Loading

rubencarvalho Jul 28, 2025 •

edited

Loading