-
Notifications
You must be signed in to change notification settings - Fork 233
fix(alert-dialog): added missing imports #5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
|
import '@spectrum-web-components/button-group/sp-button-group.js'; | ||
import '@spectrum-web-components/icons-workflow/icons/sp-icon-alert.js'; | ||
import '@spectrum-web-components/divider/sp-divider.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes import dependencies of divider and button group UI issue in AlertDialog, new VRT changes are expected.
Description
Added missing import statements for required Spectrum Web Components that are used within the AlertDialog component:
Added Stackblitz link to documentation site.
Motivation and context
The AlertDialog component renders these elements in its template but was missing the corresponding import statements. This caused the components to not be properly registered and available at runtime, leading to broken VRT (Visual Regression Tests).
Impact
✅ Fixes VRT failures for AlertDialog component
✅ Ensures proper component registration and availability
✅ Maintains visual consistency across all AlertDialog variants
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Descriptive Test Statement
Check new VRTs
Device review