Skip to content

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Aug 5, 2025

Description

Added missing import statements for required Spectrum Web Components that are used within the AlertDialog component:

@spectrum-web-components/button-group/sp-button-group.js
@spectrum-web-components/icons-workflow/icons/sp-icon-alert.js
@spectrum-web-components/divider/sp-divider.js

Added Stackblitz link to documentation site.

Motivation and context

The AlertDialog component renders these elements in its template but was missing the corresponding import statements. This caused the components to not be properly registered and available at runtime, leading to broken VRT (Visual Regression Tests).

Impact

✅ Fixes VRT failures for AlertDialog component
✅ Ensures proper component registration and availability
✅ Maintains visual consistency across all AlertDialog variants

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. See the divider and the button-group is not rendering
  • Check new VRTs

    1. Go here
    2. Compare the new UI with imports which should be the correct baseline

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@Rajdeepc Rajdeepc self-assigned this Aug 5, 2025
@Rajdeepc Rajdeepc added the bug Something isn't working label Aug 5, 2025
Copy link
Contributor

github-actions bot commented Aug 5, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5669

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Tachometer results

Currently, no packages are changed by this PR...

Copy link

changeset-bot bot commented Aug 5, 2025

⚠️ No Changeset found

Latest commit: 65b6810

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc marked this pull request as ready for review August 5, 2025 06:13
@Rajdeepc Rajdeepc requested a review from a team as a code owner August 5, 2025 06:13
@Rajdeepc Rajdeepc added the dependencies Pull requests that update a dependency file label Aug 5, 2025
Comment on lines +23 to +25
import '@spectrum-web-components/button-group/sp-button-group.js';
import '@spectrum-web-components/icons-workflow/icons/sp-icon-alert.js';
import '@spectrum-web-components/divider/sp-divider.js';
Copy link
Contributor Author

@Rajdeepc Rajdeepc Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes import dependencies of divider and button group UI issue in AlertDialog, new VRT changes are expected.

@Rajdeepc Rajdeepc changed the title fix(alert-dialog): added missed direct dependencies fix(alert-dialog): added missing imports Aug 7, 2025
@Rajdeepc Rajdeepc marked this pull request as draft August 8, 2025 12:12
@caseyisonit caseyisonit added needs jira ticket ready-for-merge Will auto-update until merged and removed ready-for-review labels Aug 14, 2025
@Rajdeepc Rajdeepc marked this pull request as ready for review August 14, 2025 16:41
@Rajdeepc Rajdeepc merged commit 4889730 into main Aug 21, 2025
24 checks passed
@Rajdeepc Rajdeepc deleted the rajdeep/alert-dialog-divider branch August 21, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file needs jira ticket ready-for-merge Will auto-update until merged SEV 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants