Skip to content

Conversation

castastrophe
Copy link
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@castastrophe castastrophe requested a review from a team as a code owner August 8, 2025 22:57
Copy link

changeset-bot bot commented Aug 8, 2025

⚠️ No Changeset found

Latest commit: ba5e466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 8, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5688

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Tachometer results

Currently, no packages are changed by this PR...

@@ -1,197 +0,0 @@
{
"root": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled these out into the root config but this could use a double check and a validation to make sure nothing was lost in the process.

@castastrophe castastrophe self-assigned this Aug 8, 2025
@castastrophe castastrophe force-pushed the castastrophe/chore-enforced-lint-order-exports branch 3 times, most recently from e0b97df to 4bcebf4 Compare August 8, 2025 23:27
@caseyisonit caseyisonit added blocked Needs discussion Proposed UX or spec changes and removed blocked labels Aug 14, 2025
@castastrophe castastrophe force-pushed the castastrophe/chore-enforced-lint-order-exports branch from 4bcebf4 to 12a76ec Compare August 18, 2025 12:50
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/help-text"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/icon"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/icons-ui"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/icons-workflow"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/icons"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/iconset"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/illustrated-message"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/infield-button"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/link"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/menu"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/meter"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/modal"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/number-field"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/overlay"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/picker-button"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/picker"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/popover"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/progress-bar"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/progress-circle"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/radio"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/search"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/sidenav"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/slider"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/split-view"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/status-light"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/swatch"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/switch"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/table"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/tabs"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/tags"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/textfield"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/thumbnail"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/toast"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/tooltip"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/top-nav"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/tray"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "packages/underlay"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/css-custom-vars-viewer"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/documentation"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/example-project-rollup"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/example-project-webpack"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/story-decorator"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/templates"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/types"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "projects/vrt-compare"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/base"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/bundle"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/grid"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/opacity-checkerboard"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/reactive-controllers"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/shared"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/styles"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/theme"


⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'directory' should be before 'url'.

"directory": "tools/truncated"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants