-
Notifications
You must be signed in to change notification settings - Fork 233
chore: enforce exports order eslint #5688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
@@ -1,197 +0,0 @@ | |||
{ | |||
"root": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled these out into the root config but this could use a double check and a validation to make sure nothing was lost in the process.
e0b97df
to
4bcebf4
Compare
4bcebf4
to
12a76ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/help-text" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/icon" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/icons-ui" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/icons-workflow" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/icons" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/iconset" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/illustrated-message" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/infield-button" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/link" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/menu" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/meter" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/modal" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/number-field" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/overlay" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/picker-button" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/picker" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/popover" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/progress-bar" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/progress-circle" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/radio" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/search" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/sidenav" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/slider" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/split-view" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/status-light" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/swatch" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/switch" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/table" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/tabs" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/tags" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/textfield" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/thumbnail" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/toast" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/tooltip" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/top-nav" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/tray" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "packages/underlay" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/css-custom-vars-viewer" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/documentation" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/example-project-rollup" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/example-project-webpack" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/story-decorator" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/templates" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/types" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "projects/vrt-compare" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/base" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/bundle" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/grid" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/opacity-checkerboard" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/reactive-controllers" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/shared" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/styles" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/theme" |
Expected object keys to be in ascending order. 'directory' should be before 'url'.
"directory": "tools/truncated" |
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review