-
Notifications
You must be signed in to change notification settings - Fork 233
chore(docs): create migration guide for Spectrum CSS to barebones [SWC-1247] #5772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: barebones
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
a8a91d2
to
7865ff9
Compare
@@ -0,0 +1,79 @@ | |||
import { Meta, Title } from '@storybook/blocks'; | |||
|
|||
<Meta title="Adobe Code of Conduct" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead and pulled this over from Spectrum CSS since it's a nice easy drop-in.
Tachometer resultsCurrently, no packages are changed by this PR... |
second-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts
Outdated
Show resolved
Hide resolved
second-gen/packages/swc/components/status-light/stories/status-light.stories.ts
Outdated
Show resolved
Hide resolved
second-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts
Outdated
Show resolved
Hide resolved
second-gen/packages/swc/components/progress-circle/stories/progress-circle.stories.ts
Outdated
Show resolved
Hide resolved
second-gen/packages/swc/components/status-light/stories/status-light.stories.ts
Outdated
Show resolved
Hide resolved
94e781c
to
4837c01
Compare
import { Meta, Title } from '@storybook/blocks'; | ||
|
||
<Meta title="Migration guide" /> | ||
<Title>Migration guide</Title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all useful and well-written!
The only thing I had in my notes that I didn't see mentioned was that in 2nd gen, components have a new naming convention (<swc-badge>
instead of <sp-badge>
), would that be useful to call out in here?
Description
Create documentation that guides developers through migrating CSS styles from the
spectrum-two
branch in the Spectrum CSS repository into thebarebones
second-generation folder structure. This guide will maintain consistency and proper CSS architecture during the transition to Spectrum Web Components S2.Motivation and context
Current State:
Related issue(s)
2nd-gen-component-analysis
branchScope and requirements
Components for reference
Using
barebones
milestone components as examples:Author's checklist
Reviewer's checklist
Manual review test cases
Verify migration process using existing barebones components
Validate documentation completeness