-
Notifications
You must be signed in to change notification settings - Fork 235
chore(overlay): overlay doc improvements #5899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 212 in 2238891
| const handleClick = async (event: MouseEvent) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 216 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 226 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 229 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 236 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 239 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-closed', with ⏎············'sp-closed',⏎···········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 241 in 2238891
| overlay.addEventListener('sp-closed', () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 242 in 2238891
| overlay.remove(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ········},·{·once:·true·}); with ············},⏎············{·once:·true·}
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 243 in 2238891
| }, { once: true }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····} with ········)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 244 in 2238891
| }; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert };⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 245 in 2238891
🚫 [eslint] <lit-a11y/click-events-have-key-events> reported by reviewdog 🐶
Clickable non-interactive elements must have at least 1 keyboard event listener
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 258 in 2238891
| <div class="click-area" @click=${handleClick}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;" with ⏎················style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 259 in 2238891
| <p style="margin: 0; color: var(--spectrum-gray-800); font-weight: bold;"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 280 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 282 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 287 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·content·was·only·created·when·you·opened·the·overlay! with ⏎··································This·content·was·only·created·when·you·opened⏎··································the·overlay!⏎······························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 299 in 2238891
| <p>This content was only created when you opened the overlay!</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·pattern·is·great·for·performance·when·you·have·many·overlays·on·a·page. with ⏎··································This·pattern·is·great·for·performance·when·you⏎··································have·many·overlays·on·a·page.⏎······························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 300 in 2238891
| <p>This pattern is great for performance when you have many overlays on a page.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 301 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 309 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 330 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>💡·Performance·tip:</strong>·The·overlay·content·is·only·created·when·you·click·the·button,·reducing·memory·usage·for·pages·with·many·overlays. with ⏎····················<strong>💡·Performance·tip:</strong>⏎····················The·overlay·content·is·only·created·when·you·click·the⏎····················button,·reducing·memory·usage·for·pages·with·many·overlays.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 332 in 2238891
| <p><strong>💡 Performance tip:</strong> The overlay content is only created when you click the button, reducing memory usage for pages with many overlays.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 349 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 351 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 356 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 361 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 362 in 2238891
| const nextStep = () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 366 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 367 in 2238891
| const prevStep = () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 371 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 372 in 2238891
| const updateContent = () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 375 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 400 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 402 in 2238891
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 403 in 2238891
| const prevBtn = document.querySelector('#prev-btn') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 404 in 2238891
| const nextBtn = document.querySelector('#next-btn') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 405 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 409 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎················trigger="wizard-trigger@click"·⏎················type="modal"⏎············ with trigger="wizard-trigger@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Lines 429 to 432 in 2238891
| <sp-overlay | |
| trigger="wizard-trigger@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·placeholder="Full·Name" with ⏎································placeholder="Full·Name"⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 438 in 2238891
| <sp-textfield placeholder="Full Name"></sp-textfield> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 441 in 2238891
| <sp-button |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 443 in 2238891
| variant="secondary" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 449 in 2238891
| <sp-button |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 451 in 2238891
| variant="accent" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 475 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 477 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 482 in 2238891
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 486 in 2238891
| const openSubmenu = async (event: MouseEvent, items: string[]) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 489 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 493 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace (item with ((item)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 498 in 2238891
| ${items.map(item => `<sp-menu-item>${item}</sp-menu-item>`).join('')} |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 501 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············buttonRect.right,⏎············buttonRect.top⏎········ with buttonRect.right,·buttonRect.top
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Lines 503 to 506 in 2238891
| const trigger = new VirtualTrigger( | |
| buttonRect.right, | |
| buttonRect.top | |
| ); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 507 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 513 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 516 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-closed', with ⏎············'sp-closed',⏎···········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 517 in 2238891
| overlay.addEventListener('sp-closed', () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 518 in 2238891
| overlay.remove(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ········},·{·once:·true·}); with ············},⏎············{·once:·true·}
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 519 in 2238891
| }, { once: true }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace } with ····)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 520 in 2238891
| }; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert };⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 521 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 536 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 537 in 2238891
| trigger="cascading-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 538 in 2238891
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 546 in 2238891
| <sp-menu-item |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 547 in 2238891
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 547 in 2238891
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 548 in 2238891
| openSubmenu(e, ['Import from File', 'Import from URL', 'Import from Clipboard']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'Import·from·File',·'Import·from·URL',·'Import·from·Clipboard']) with ⏎····································'Import·from·File',⏎····································'Import·from·URL',⏎····································'Import·from·Clipboard',
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 548 in 2238891
| openSubmenu(e, ['Import from File', 'Import from URL', 'Import from Clipboard']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····])
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 549 in 2238891
| } |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 557 in 2238891
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 557 in 2238891
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 558 in 2238891
| openSubmenu(e, ['Export as PDF', 'Export as PNG', 'Export as SVG']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'Export·as·PDF',·'Export·as·PNG',·'Export·as·SVG']) with ⏎····································'Export·as·PDF',⏎····································'Export·as·PNG',⏎····································'Export·as·SVG',
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 558 in 2238891
| openSubmenu(e, ['Export as PDF', 'Export as PNG', 'Export as SVG']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····])
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 559 in 2238891
| } |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 36 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 38 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 40 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="scroll-trigger@click"·type="auto"·placement="right" with ⏎························trigger="scroll-trigger@click"⏎························type="auto"⏎························placement="right"⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 67 in 2238891
| <sp-overlay trigger="scroll-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·overlay·stays·positioned·correctly·even·when·you·scroll·the·container. with ⏎····································This·overlay·stays·positioned·correctly·even⏎····································when·you·scroll·the·container.⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 70 in 2238891
| <p>This overlay stays positioned correctly even when you scroll the container.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 95 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 97 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 99 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·element·has·a·high·z-index,·but·overlays·still·appear·on·top. with ⏎····················This·element·has·a·high·z-index,·but·overlays·still·appear⏎····················on·top.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 122 in 2238891
| <p>This element has a high z-index, but overlays still appear on top.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="zindex-trigger@click"·type="auto"·placement="top" with ⏎····················trigger="zindex-trigger@click"⏎····················type="auto"⏎····················placement="top"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 126 in 2238891
| <sp-overlay trigger="zindex-trigger@click" type="auto" placement="top"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ✅·This·overlay·correctly·appears·above·all·content with ⏎································✅·This·overlay·correctly·appears·above·all⏎································content⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 129 in 2238891
| <p>✅ This overlay correctly appears above all content</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Overlays·are·rendered·in·a·top-level·container·to·avoid·z-index·issues. with ⏎································Overlays·are·rendered·in·a·top-level·container⏎································to·avoid·z-index·issues.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 130 in 2238891
| <p>Overlays are rendered in a top-level container to avoid z-index issues.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 150 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 152 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 154 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 159 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 160 in 2238891
| const toggleContent = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 162 in 2238891
| const overlay = document.querySelector('#dynamic-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 164 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 166 in 2238891
| content.innerHTML = expanded |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 169 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace module with ⏎················(module)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 171 in 2238891
| import('@spectrum-web-components/overlay/sp-overlay.js').then(module => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 172 in 2238891
| (module as any).Overlay?.update(); |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 172 in 2238891
| (module as any).Overlay?.update(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace } with ····}⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 173 in 2238891
| }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 176 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 185 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 187 in 2238891
| trigger="dynamic-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 188 in 2238891
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 217 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 219 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 221 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="rapid-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="rapid-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 239 in 2238891
| <sp-overlay trigger="rapid-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Try·clicking·the·trigger·button·multiple·times·quickly. with ⏎····························Try·clicking·the·trigger·button·multiple·times⏎····························quickly.⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 242 in 2238891
| <p>Try clicking the trigger button multiple times quickly.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Try·this:</strong>·Click·the·button·multiple·times·as·fast·as·you·can.·The·overlay·system·automatically·handles·rapid·interactions·without·getting·stuck·or·creating·multiple·overlays. with ⏎····················<strong>Try·this:</strong>⏎····················Click·the·button·multiple·times·as·fast·as·you·can.·The⏎····················overlay·system·automatically·handles·rapid·interactions⏎····················without·getting·stuck·or·creating·multiple·overlays.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 248 in 2238891
| <p><strong>Try this:</strong> Click the button multiple times as fast as you can. The overlay system automatically handles rapid interactions without getting stuck or creating multiple overlays.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 265 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 267 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 269 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="first-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="first-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 281 in 2238891
| <sp-overlay trigger="first-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Open·Second·Overlay with ⏎····························Open·Second·Overlay⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 285 in 2238891
| <sp-button id="second-trigger">Open Second Overlay</sp-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="second-trigger@click"·type="auto"·placement="right" with ⏎····························trigger="second-trigger@click"⏎····························type="auto"⏎····························placement="right"⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 286 in 2238891
| <sp-overlay trigger="second-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Open·Third·Overlay with ⏎········································Open·Third·Overlay⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 290 in 2238891
| <sp-button id="third-trigger">Open Third Overlay</sp-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="third-trigger@click"·type="auto"·placement="right" with ⏎········································trigger="third-trigger@click"⏎········································type="auto"⏎········································placement="right"⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 291 in 2238891
| <sp-overlay trigger="third-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Third·overlay·(highest·in·stack) with ⏎····················································Third·overlay·(highest·in⏎····················································stack)⏎················································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 294 in 2238891
| <p>Third overlay (highest in stack)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Press·ESC·to·close·overlays·in·order with ⏎····················································Press·ESC·to·close·overlays⏎····················································in·order⏎················································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 295 in 2238891
| <p>Press ESC to close overlays in order</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 320 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 322 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 324 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="long-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="long-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 339 in 2238891
| <sp-overlay trigger="long-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace .fill(0).map( with ⏎································.fill(0)⏎································.map(⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 344 in 2238891
| ${Array(20).fill(0).map((_, i) => html` |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 345 in 2238891
| <p>Content paragraph ${i + 1}</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ``` with ········⏎································`
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 346 in 2238891
| `)} |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 366 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 368 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 370 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Responsive·behavior:</strong>·On·small·screens,·use·type="page"·for·full-screen·overlays·that·are·easier·to·interact·with. with ⏎····················<strong>Responsive·behavior:</strong>⏎····················On·small·screens,·use·type="page"·for·full-screen·overlays⏎····················that·are·easier·to·interact·with.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 398 in 2238891
| <p><strong>Responsive behavior:</strong> On small screens, use type="page" for full-screen overlays that are easier to interact with.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="mobile-trigger@click"·type="page"·placement="bottom" with ⏎····················trigger="mobile-trigger@click"⏎····················type="page"⏎····················placement="bottom"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 403 in 2238891
| <sp-overlay trigger="mobile-trigger@click" type="page" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace On·mobile,·overlays·can·take·full·screen·for·better·usability. with ⏎································On·mobile,·overlays·can·take·full·screen·for⏎································better·usability.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 407 in 2238891
| <p>On mobile, overlays can take full screen for better usability.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 432 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 434 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 436 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Clipping·workaround:</strong>·Even·though·the·parent·has·overflow:hidden,·the·overlay·renders·correctly·because·it's·placed·in·a·top-level·container. with ⏎····················<strong>Clipping·workaround:</strong>⏎····················Even·though·the·parent·has·overflow:hidden,·the·overlay⏎····················renders·correctly·because·it's·placed·in·a·top-level⏎····················container.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 459 in 2238891
| <p><strong>Clipping workaround:</strong> Even though the parent has overflow:hidden, the overlay renders correctly because it's placed in a top-level container.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="clip-trigger@click"·type="auto"·placement="bottom" with ⏎····················trigger="clip-trigger@click"⏎····················type="auto"⏎····················placement="bottom"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 464 in 2238891
| <sp-overlay trigger="clip-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 38 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 40 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 46 in 2238891
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 50 in 2238891
| const validateEmail = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 52 in 2238891
| const overlay = document.querySelector('#email-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 54 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 58 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 74 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 79 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 110 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 112 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 117 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 142 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·id="password-help"·variant="secondary"·size="m"·quiet with ⏎····················id="password-help"⏎····················variant="secondary"⏎····················size="m"⏎····················quiet⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 148 in 2238891
| <sp-button id="password-help" variant="secondary" size="m" quiet> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 151 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Contains·uppercase·and·lowercase·letters with ⏎····································Contains·uppercase·and·lowercase·letters⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 161 in 2238891
| <li>Contains uppercase and lowercase letters</li> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Contains·at·least·one·special·character·(!@#$%^&*) with ⏎····································Contains·at·least·one·special·character⏎····································(!@#$%^&*)⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 163 in 2238891
| <li>Contains at least one special character (!@#$%^&*)</li> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 184 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 186 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 191 in 2238891
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 195 in 2238891
| const validateUsername = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 197 in 2238891
| const overlay = document.querySelector('#username-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 199 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 203 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 204 in 2238891
| const validatePassword = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 206 in 2238891
| const overlay = document.querySelector('#password-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 208 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 212 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 213 in 2238891
| const validateConfirm = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 215 in 2238891
| const overlay = document.querySelector('#confirm-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace '#password-field-multi' with ⏎············'#password-field-multi'⏎········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 216 in 2238891
| const passwordField = document.querySelector('#password-field-multi') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 216 in 2238891
| const passwordField = document.querySelector('#password-field-multi') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 218 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 222 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 235 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 240 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 245 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Username·must·be·at·least·3·characters·and·contain·only·letters,·numbers,·and·underscores with ⏎································Username·must·be·at·least·3·characters·and⏎································contain·only·letters,·numbers,·and·underscores⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 253 in 2238891
| <p>Username must be at least 3 characters and contain only letters, numbers, and underscores</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 258 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 263 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 269 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 282 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 287 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 293 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 306 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 323 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 325 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 330 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 346 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Country⏎················ with Country
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Lines 348 to 350 in 2238891
| <sp-field-label for="country-picker"> | |
| Country | |
| </sp-field-label> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 362 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Time·zone⏎················ with Time·zone
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Lines 364 to 366 in 2238891
| <sp-field-label for="timezone-picker"> | |
| Time zone | |
| </sp-field-label> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Pacific·Standard·Time·(PST) with ⏎························Pacific·Standard·Time·(PST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 368 in 2238891
| <sp-menu-item value="pst">Pacific Standard Time (PST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Mountain·Standard·Time·(MST) with ⏎························Mountain·Standard·Time·(MST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 369 in 2238891
| <sp-menu-item value="mst">Mountain Standard Time (MST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Central·Standard·Time·(CST) with ⏎························Central·Standard·Time·(CST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 370 in 2238891
| <sp-menu-item value="cst">Central Standard Time (CST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Eastern·Standard·Time·(EST) with ⏎························Eastern·Standard·Time·(EST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 371 in 2238891
| <sp-menu-item value="est">Eastern Standard Time (EST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Coordinated·Universal·Time·(UTC) with ⏎························Coordinated·Universal·Time·(UTC)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 372 in 2238891
| <sp-menu-item value="utc">Coordinated Universal Time (UTC)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Greenwich·Mean·Time·(GMT) with ⏎························Greenwich·Mean·Time·(GMT)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 373 in 2238891
| <sp-menu-item value="gmt">Greenwich Mean Time (GMT)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 391 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 393 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 398 in 2238891
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 402 in 2238891
| const handleSave = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 403 in 2238891
| const nameField = document.querySelector('#edit-name-field') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 404 in 2238891
| const emailField = document.querySelector('#edit-email-field') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 405 in 2238891
| const display = document.querySelector('#user-info-display') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 406 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 413 in 2238891
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 414 in 2238891
| const overlay = document.querySelector('#edit-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 417 in 2238891
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 418 in 2238891
| const handleCancel = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 419 in 2238891
| const overlay = document.querySelector('#edit-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 422 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <br with ⏎····················<br·/
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 448 in 2238891
| <strong>John Doe</strong><br> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 454 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 466 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···························· with ⏎····························<sp-field-label
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 470 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····························<sp-field-label·for="edit-email-field"·style="margin-top:·15px;" with ································for="edit-email-field"⏎································style="margin-top:·15px;"⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 471 in 2238891
| <sp-field-label for="edit-email-field" style="margin-top: 15px;"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 474 in 2238891
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 478 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·variant="secondary"·@click=${handleCancel} with ⏎····································variant="secondary"⏎····································@click=${handleCancel}⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 480 in 2238891
| <sp-button variant="secondary" @click=${handleCancel}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·variant="accent"·@click=${handleSave} with ⏎····································variant="accent"⏎····································@click=${handleSave}⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 483 in 2238891
| <sp-button variant="accent" @click=${handleSave}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····openOverlay,⏎····VirtualTrigger,⏎ with ·openOverlay,·VirtualTrigger·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 23 to 26 in 2238891
| import { | |
| openOverlay, | |
| VirtualTrigger, | |
| } from '@spectrum-web-components/overlay'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 98 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 100 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 102 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Save⏎················ with Save
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 110 to 112 in 2238891
| <sp-action-button id="tooltip-example"> | |
| Save | |
| </sp-action-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 113 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 114 in 2238891
| trigger="tooltip-example@hover" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 115 in 2238891
| type="hint" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>trigger</code>·attribute·connects·the·tooltip·to·your·button⏎····················using·the·button's·ID.·The·<code>@hover</code> with ⏎····················<code>trigger</code>⏎····················attribute·connects·the·tooltip·to·your·button·using·the⏎····················button's·ID.·The⏎····················<code>@hover</code>⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 126 to 127 in 2238891
| The <code>trigger</code> attribute connects the tooltip to your button | |
| using the button's ID. The <code>@hover</code> part tells it to show on hover. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Hover·over·the·Save·button·above</p> with ⏎····················👆·Try·it:·Hover·over·the·Save·button·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 129 in 2238891
| <p class="try-it">👆 Try it: Hover over the Save button above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 130 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>trigger:</strong>·Connects·to·button·using·"id@interaction" with ⏎····················•⏎····················<strong>trigger:</strong>⏎····················Connects·to·button·using·"id@interaction"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 146 in 2238891
| <p>• <strong>trigger:</strong> Connects to button using "id@interaction"</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="hint":</strong>·Non-blocking,·won't·interfere·with·page with ⏎····················•⏎····················<strong>type="hint":</strong>⏎····················Non-blocking,·won't·interfere·with·page⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 147 in 2238891
| <p>• <strong>type="hint":</strong> Non-blocking, won't interfere with page</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>placement:</strong>·Where·tooltip·appears·(top,·bottom,·left,·right) with ⏎····················•⏎····················<strong>placement:</strong>⏎····················Where·tooltip·appears·(top,·bottom,·left,·right)⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 148 in 2238891
| <p>• <strong>placement:</strong> Where tooltip appears (top, bottom, left, right)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>delayed:</strong>·Small·delay·before·showing·(better·UX) with ⏎····················•⏎····················<strong>delayed:</strong>⏎····················Small·delay·before·showing·(better·UX)⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 149 in 2238891
| <p>• <strong>delayed:</strong> Small delay before showing (better UX)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 161 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 163 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 165 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 176 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 177 in 2238891
| trigger="popover-example@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 178 in 2238891
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·is·a·simple·popover·with·some·helpful·information. with ⏎································This·is·a·simple·popover·with·some·helpful⏎································information.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 184 in 2238891
| <p>This is a simple popover with some helpful information.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>@click</code>·instead·of·<code>@hover</code>. with ⏎····················<code>@click</code>⏎····················instead·of⏎····················<code>@hover</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 194 in 2238891
| Similar to tooltips, but uses <code>@click</code> instead of <code>@hover</code>. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·The·popover·automatically·closes·when·you·click·outside·or with ·.·The·popover·automatically·closes·when·you·click·outside·or⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 195 in 2238891
| The popover automatically closes when you click outside or press Escape. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Click·the·"Show·Details"·button·above</p> with ⏎····················👆·Try·it:·Click·the·"Show·Details"·button·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 197 in 2238891
| <p class="try-it">👆 Try it: Click the "Show Details" button above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 198 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>@click:</strong>·Opens·on·button·click with ⏎····················•⏎····················<strong>@click:</strong>⏎····················Opens·on·button·click⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 218 in 2238891
| <p>• <strong>@click:</strong> Opens on button click</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="auto":</strong>·Closes·when·clicking·outside with ⏎····················•⏎····················<strong>type="auto":</strong>⏎····················Closes·when·clicking·outside⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 219 in 2238891
| <p>• <strong>type="auto":</strong> Closes when clicking outside</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-popover:</strong>·Container·for·popover·content with ⏎····················•⏎····················<strong>sp-popover:</strong>⏎····················Container·for·popover·content⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 220 in 2238891
| <p>• <strong>sp-popover:</strong> Container for popover content</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-dialog:</strong>·Provides·consistent·spacing·and·styling with ⏎····················•⏎····················<strong>sp-dialog:</strong>⏎····················Provides·consistent·spacing·and·styling⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 221 in 2238891
| <p>• <strong>sp-dialog:</strong> Provides consistent spacing and styling</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 233 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 235 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 237 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················trigger="modal-example@click"·⏎····················type="modal"⏎················ with trigger="modal-example@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 248 to 251 in 2238891
| <sp-overlay | |
| trigger="modal-example@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-overlay[trigger="modal-example@click"]' with ⏎································'sp-overlay[trigger="modal-example@click"]'⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 259 in 2238891
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 259 in 2238891
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-overlay[trigger="modal-example@click"]' with ⏎································'sp-overlay[trigger="modal-example@click"]'⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 263 in 2238891
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 263 in 2238891
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·The·underlay·dims
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 275 in 2238891
| Modal dialogs block interaction with the page until closed. The underlay dims |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·the·background·to·focus·attention.·Use·<code>sp-dialog-wrapper</code>·for with ·The·underlay·dims·the·background·to·focus·attention.·Use⏎····················<code>sp-dialog-wrapper</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 276 in 2238891
| the background to focus attention. Use <code>sp-dialog-wrapper</code> for |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·for
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 277 in 2238891
| built-in action buttons. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Click·"Delete·Item"·to·see·the·modal</p> with ⏎····················👆·Try·it:·Click·"Delete·Item"·to·see·the·modal
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 279 in 2238891
| <p class="try-it">👆 Try it: Click "Delete Item" to see the modal</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 280 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="modal":</strong>·Blocks·page·interaction with ⏎····················•⏎····················<strong>type="modal":</strong>⏎····················Blocks·page·interaction⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 303 in 2238891
| <p>• <strong>type="modal":</strong> Blocks page interaction</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>underlay:</strong>·Dims·background with ⏎····················•⏎····················<strong>underlay:</strong>⏎····················Dims·background⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 304 in 2238891
| <p>• <strong>underlay:</strong> Dims background</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-dialog-wrapper:</strong>·Provides·action·buttons with ⏎····················•⏎····················<strong>sp-dialog-wrapper:</strong>⏎····················Provides·action·buttons⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 305 in 2238891
| <p>• <strong>sp-dialog-wrapper:</strong> Provides action buttons</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>@confirm/@cancel:</strong>·Handle·button·clicks with ⏎····················•⏎····················<strong>@confirm/@cancel:</strong>⏎····················Handle·button·clicks⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 306 in 2238891
| <p>• <strong>@confirm/@cancel:</strong> Handle button clicks</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 318 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 320 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 322 in 2238891
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 326 in 2238891
| const handleContextMenu = async (event: MouseEvent) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 328 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 332 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 344 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 347 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 355 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 358 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-closed', with ⏎············'sp-closed',⏎···········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 360 in 2238891
| overlay.addEventListener('sp-closed', () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 361 in 2238891
| overlay.remove(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace },·{·once:·true·}); with ····},⏎············{·once:·true·}
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 362 in 2238891
| }, { once: true }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert );⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 363 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 369 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 374 in 2238891
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;" with ⏎························style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;"⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 386 in 2238891
| <p style="margin: 0; color: var(--spectrum-gray-800); font-weight: bold;"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>VirtualTrigger</code>·to with ⏎····················<code>VirtualTrigger</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 395 in 2238891
| Context menus use the imperative API with <code>VirtualTrigger</code> to |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·position·the·menu·at·the·cursor.·This·requires·more·code·but·gives·you with ·to·position·the·menu·at·the·cursor.·This·requires·more·code
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 396 in 2238891
| position the menu at the cursor. This requires more code but gives you |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·but·gives·you
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 397 in 2238891
| full control. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Right-click·in·the·shaded·area·above</p> with ⏎····················👆·Try·it:·Right-click·in·the·shaded·area·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 399 in 2238891
| <p class="try-it">👆 Try it: Right-click in the shaded area above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 400 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>VirtualTrigger:</strong>·Position·at·cursor·coordinates with ⏎····················•⏎····················<strong>VirtualTrigger:</strong>⏎····················Position·at·cursor·coordinates⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 432 in 2238891
| <p>• <strong>VirtualTrigger:</strong> Position at cursor coordinates</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>openOverlay():</strong>·Programmatic·API·for·advanced·control with ⏎····················•⏎····················<strong>openOverlay():</strong>⏎····················Programmatic·API·for·advanced·control⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 433 in 2238891
| <p>• <strong>openOverlay():</strong> Programmatic API for advanced control</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>event.preventDefault():</strong>·Suppress·browser·context·menu with ⏎····················•⏎····················<strong>event.preventDefault():</strong>⏎····················Suppress·browser·context·menu⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 434 in 2238891
| <p>• <strong>event.preventDefault():</strong> Suppress browser context menu</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>notImmediatelyClosable:</strong>·Prevents·instant·closing·on·right-click with ⏎····················•⏎····················<strong>notImmediatelyClosable:</strong>⏎····················Prevents·instant·closing·on·right-click⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 435 in 2238891
| <p>• <strong>notImmediatelyClosable:</strong> Prevents instant closing on right-click</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 447 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·menus,
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 495 in 2238891
| See real-world examples of validation popovers, action menus, |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·menus,
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 496 in 2238891
| help systems, and more with complete code samples. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 498 in 2238891
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 499 in 2238891
| window.location.hash = '#overlay-patterns-examples-common-patterns--tooltip-pattern'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 500 in 2238891
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·available
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 508 in 2238891
| Dive deep into all the options, attributes, and events available |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·for·sp-overlay,·overlay-trigger,·and·the·trigger() with ·available·for·sp-overlay,·overlay-trigger,·and·the·trigger()⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 509 in 2238891
| for sp-overlay, overlay-trigger, and the trigger() directive. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 511 in 2238891
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 512 in 2238891
| window.location.hash = '#overlay-api-reference-sp-overlay--modal'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 513 in 2238891
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 524 in 2238891
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 525 in 2238891
| window.location.hash = '#overlay-edge-cases-troubleshooting-edge-cases--nested-scrolling'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 526 in 2238891
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 537 in 2238891
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 538 in 2238891
| window.location.hash = '#overlay-edge-cases-troubleshooting-troubleshooting--wont-open'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 539 in 2238891
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 86 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 88 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 90 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·The·button·ID·is·"correct-id"·but·the·overlay·is·looking·for with ⏎····················The·button·ID·is·"correct-id"·but·the·overlay·is·looking·for⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 108 in 2238891
| <strong>Problem:</strong> The button ID is "correct-id" but the overlay is looking for "wrong-id". |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 113 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 125 in 2238891
| <strong>Solution:</strong> Button ID matches the trigger attribute. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 145 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 147 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 149 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·type="inline"·doesn't·auto-close,·and·button·doesn't·trigger with ⏎····················type="inline"·doesn't·auto-close,·and·button·doesn't·trigger⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 168 in 2238891
| <strong>Problem:</strong> type="inline" doesn't auto-close, and button doesn't trigger close event. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 171 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎·······························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 179 in 2238891
| <sp-button @click=${(e: Event) => { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 179 in 2238891
| <sp-button @click=${(e: Event) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace e.target?.dispatchEvent(new·Event('close',·{·bubbles:·true·}) with ····e.target?.dispatchEvent(⏎········································new·Event('close',·{·bubbles:·true·})⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 180 in 2238891
| e.target?.dispatchEvent(new Event('close', { bubbles: true })); |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 180 in 2238891
| e.target?.dispatchEvent(new Event('close', { bubbles: true })); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 181 in 2238891
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 188 in 2238891
| <strong>Solution:</strong> Button dispatches 'close' event that bubbles to overlay. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 211 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 213 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 215 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Placement·defaults·to·'top'·which·might·not·be·what·you·want. with ⏎································Placement·defaults·to·'top'·which·might·not·be⏎································what·you·want.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 228 in 2238891
| <p>Placement defaults to 'top' which might not be what you want.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 233 in 2238891
| <strong>Problem:</strong> No placement specified, uses default. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 236 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="with-placement-trigger@click"·type="auto"·placement="bottom-start" with ⏎····················trigger="with-placement-trigger@click"⏎····················type="auto"⏎····················placement="bottom-start"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 240 in 2238891
| <sp-overlay trigger="with-placement-trigger@click" type="auto" placement="bottom-start"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 248 in 2238891
| <strong>Solution:</strong> Specify placement explicitly. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Options:</strong>·top,·bottom,·left,·right·(with·-start/-end·variants) with ⏎························<strong>Options:</strong>⏎························top,·bottom,·left,·right·(with·-start/-end·variants)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 250 in 2238891
| <p><strong>Options:</strong> top, bottom, left, right (with -start/-end variants)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 268 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 270 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 272 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 282 in 2238891
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 283 in 2238891
| trigger="no-focus-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·Modal·overlay·should·receive·focus·but with ⏎····················Modal·overlay·should·receive·focus·but⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 295 in 2238891
| <strong>Problem:</strong> Modal overlay should receive focus but receives-focus="false" disables it. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 298 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················trigger="with-focus-trigger@click"·⏎····················type="modal"⏎················ with trigger="with-focus-trigger@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Lines 302 to 305 in 2238891
| <sp-overlay | |
| trigger="with-focus-trigger@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·Remove·receives-focus="false"·or·set·to·"auto"·for·default with ⏎····················Remove·receives-focus="false"·or·set·to·"auto"·for·default⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 314 in 2238891
| <strong>Solution:</strong> Remove receives-focus="false" or set to "auto" for default behavior. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 334 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 336 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 338 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····························Popover⏎························ with Popover
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Lines 353 to 355 in 2238891
| <sp-dialog size="s" no-divider> | |
| Popover | |
| </sp-dialog> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 359 in 2238891
| <strong>Problem:</strong> Multiple sp-overlay elements can conflict. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 362 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 377 in 2238891
| <strong>Solution:</strong> Use overlay-trigger for multiple interactions. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 399 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 401 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 403 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Problem:</strong>·With·many·overlays,·all·content·is·in·DOM: with ⏎························<strong>Problem:</strong>⏎························With·many·overlays,·all·content·is·in·DOM:⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 413 in 2238891
| <p><strong>Problem:</strong> With many overlays, all content is in DOM:</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Result:·100·popovers·×·200·nodes·=·<strong>20,000·DOM·nodes</strong></p with ⏎························Result:·100·popovers·×·200·nodes·=⏎························<strong>20,000·DOM·nodes</strong
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 422 in 2238891
| <p>Result: 100 popovers × 200 nodes = <strong>20,000 DOM nodes</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace </div with ····</p
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 423 in 2238891
| </div> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 424 in 2238891
| </div> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </div>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 425 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Solution:</strong>·Use·slottable-request·to·load·content·on·demand: with ⏎························<strong>Solution:</strong>⏎························Use·slottable-request·to·load·content·on·demand:⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 429 in 2238891
| <p><strong>Solution:</strong> Use slottable-request to load content on demand:</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Result:·Only·1-2·active·overlays·=·<strong>200-400·DOM·nodes</strong> with ⏎························Result:·Only·1-2·active·overlays·=⏎························<strong>200-400·DOM·nodes</strong>⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 443 in 2238891
| <p>Result: Only 1-2 active overlays = <strong>200-400 DOM nodes</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 💡·<strong>90%·reduction·in·memory!</strong> with ⏎························💡⏎························<strong>90%·reduction·in·memory!</strong>⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 444 in 2238891
| <p>💡 <strong>90% reduction in memory!</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 462 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 464 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 466 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 475 in 2238891
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 476 in 2238891
| id="div-trigger-wrong" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 489 in 2238891
| <strong>Problem:</strong> Div element can't receive keyboard focus. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 493 in 2238891
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 496 in 2238891
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 497 in 2238891
| id="div-trigger-fixed" |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 501 in 2238891
| @keydown=${(e: KeyboardEvent) => { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 502 in 2238891
| if (e.key === 'Enter' || e.key === ' ') { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 502 in 2238891
| if (e.key === 'Enter' || e.key === ' ') { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 503 in 2238891
| e.preventDefault(); |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 504 in 2238891
| (e.target as HTMLElement).click(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 518 in 2238891
| <strong>Solution:</strong> Add tabindex, role, and keyboard handler. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 💡·<strong>Better:</strong>·Use·sp-button·for·built-in·accessibility. with ⏎························💡⏎························<strong>Better:</strong>⏎························Use·sp-button·for·built-in·accessibility.⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 524 in 2238891
| <p>💡 <strong>Better:</strong> Use sp-button for built-in accessibility.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/utilities/story-helpers.ts
Line 27 in 2238891
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
| import { html, TemplateResult, render } from '@spectrum-web-components/base'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <sort-imports> reported by reviewdog 🐶
Member 'render' of the import declaration should be sorted alphabetically.
| import { html, TemplateResult, render } from '@spectrum-web-components/base'; | |
| import { html, render, TemplateResult } from '@spectrum-web-components/base'; |
|
|
||
| /** | ||
| * Nested overlays - overlay within overlay | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
| * Nested overlays - overlay within overlay | ||
| * | ||
| * **Use case:** Multi-level interactions like menus with submenus | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
| * - Proper z-index stacking | ||
| * - Independent lifecycle management | ||
| * - ESC key closes in order (most recent first) | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
| <sp-button id="first-trigger" variant="primary"> | ||
| Open First Overlay | ||
| </sp-button> | ||
| <sp-overlay trigger="first-trigger@click" type="auto" placement="bottom"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="first-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="first-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
| <sp-overlay trigger="first-trigger@click" type="auto" placement="bottom"> | |
| <sp-overlay | |
| trigger="first-trigger@click" | |
| type="auto" | |
| placement="bottom" | |
| > |
| <sp-overlay | ||
| id="dynamic-overlay" | ||
| trigger="dynamic-trigger@click" | ||
| type="auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| type="auto" | |
| type="auto" |
| </ul> | ||
| <div class="action-buttons"> | ||
| <sp-button @click=${addItem}>Add Item</sp-button> | ||
| <sp-button @click=${removeItem} variant="secondary">Remove Item</sp-button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Remove·Item with ⏎································Remove·Item⏎····························
| <sp-button @click=${removeItem} variant="secondary">Remove Item</sp-button> | |
| <sp-button @click=${removeItem} variant="secondary"> | |
| Remove Item | |
| </sp-button> |
|
|
||
| /** | ||
| * Virtual positioning - position overlay at specific coordinates | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
| * Virtual positioning - position overlay at specific coordinates | ||
| * | ||
| * **Use case:** Context menus, coordinate-based positioning | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
| * - Position at any x,y coordinates | ||
| * - No DOM trigger element required | ||
| * - Useful for mouse-based interactions | ||
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * | |
| * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 372 in 399a683
| const updateContent = () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 375 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 400 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 402 in 399a683
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 403 in 399a683
| const prevBtn = document.querySelector('#prev-btn') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 404 in 399a683
| const nextBtn = document.querySelector('#next-btn') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 405 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 409 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎················trigger="wizard-trigger@click"·⏎················type="modal"⏎············ with trigger="wizard-trigger@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Lines 429 to 432 in 399a683
| <sp-overlay | |
| trigger="wizard-trigger@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·placeholder="Full·Name" with ⏎································placeholder="Full·Name"⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 438 in 399a683
| <sp-textfield placeholder="Full Name"></sp-textfield> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 441 in 399a683
| <sp-button |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 443 in 399a683
| variant="secondary" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 449 in 399a683
| <sp-button |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 451 in 399a683
| variant="accent" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 475 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 477 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 482 in 399a683
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 486 in 399a683
| const openSubmenu = async (event: MouseEvent, items: string[]) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 489 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 493 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace (item with ((item)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 498 in 399a683
| ${items.map(item => `<sp-menu-item>${item}</sp-menu-item>`).join('')} |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 501 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎············buttonRect.right,⏎············buttonRect.top⏎········ with buttonRect.right,·buttonRect.top
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Lines 503 to 506 in 399a683
| const trigger = new VirtualTrigger( | |
| buttonRect.right, | |
| buttonRect.top | |
| ); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 507 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 513 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 516 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-closed', with ⏎············'sp-closed',⏎···········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 517 in 399a683
| overlay.addEventListener('sp-closed', () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 518 in 399a683
| overlay.remove(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ········},·{·once:·true·}); with ············},⏎············{·once:·true·}
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 519 in 399a683
| }, { once: true }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace } with ····)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 520 in 399a683
| }; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert };⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 521 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 536 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 537 in 399a683
| trigger="cascading-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 538 in 399a683
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 546 in 399a683
| <sp-menu-item |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 547 in 399a683
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 547 in 399a683
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 548 in 399a683
| openSubmenu(e, ['Import from File', 'Import from URL', 'Import from Clipboard']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'Import·from·File',·'Import·from·URL',·'Import·from·Clipboard']) with ⏎····································'Import·from·File',⏎····································'Import·from·URL',⏎····································'Import·from·Clipboard',
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 548 in 399a683
| openSubmenu(e, ['Import from File', 'Import from URL', 'Import from Clipboard']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····])
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 549 in 399a683
| } |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 557 in 399a683
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 557 in 399a683
| @mouseenter=${(e: MouseEvent) => |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 558 in 399a683
| openSubmenu(e, ['Export as PDF', 'Export as PNG', 'Export as SVG']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'Export·as·PDF',·'Export·as·PNG',·'Export·as·SVG']) with ⏎····································'Export·as·PDF',⏎····································'Export·as·PNG',⏎····································'Export·as·SVG',
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 558 in 399a683
| openSubmenu(e, ['Export as PDF', 'Export as PNG', 'Export as SVG']) |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····])
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-advanced-patterns.stories.ts
Line 559 in 399a683
| } |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 36 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 38 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 40 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="scroll-trigger@click"·type="auto"·placement="right" with ⏎························trigger="scroll-trigger@click"⏎························type="auto"⏎························placement="right"⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 67 in 399a683
| <sp-overlay trigger="scroll-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·overlay·stays·positioned·correctly·even·when·you·scroll·the·container. with ⏎····································This·overlay·stays·positioned·correctly·even⏎····································when·you·scroll·the·container.⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 70 in 399a683
| <p>This overlay stays positioned correctly even when you scroll the container.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 95 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 97 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 99 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·element·has·a·high·z-index,·but·overlays·still·appear·on·top. with ⏎····················This·element·has·a·high·z-index,·but·overlays·still·appear⏎····················on·top.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 122 in 399a683
| <p>This element has a high z-index, but overlays still appear on top.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="zindex-trigger@click"·type="auto"·placement="top" with ⏎····················trigger="zindex-trigger@click"⏎····················type="auto"⏎····················placement="top"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 126 in 399a683
| <sp-overlay trigger="zindex-trigger@click" type="auto" placement="top"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ✅·This·overlay·correctly·appears·above·all·content with ⏎································✅·This·overlay·correctly·appears·above·all⏎································content⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 129 in 399a683
| <p>✅ This overlay correctly appears above all content</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Overlays·are·rendered·in·a·top-level·container·to·avoid·z-index·issues. with ⏎································Overlays·are·rendered·in·a·top-level·container⏎································to·avoid·z-index·issues.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 130 in 399a683
| <p>Overlays are rendered in a top-level container to avoid z-index issues.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 150 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 152 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 154 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 159 in 399a683
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 160 in 399a683
| const toggleContent = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 162 in 399a683
| const overlay = document.querySelector('#dynamic-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 164 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 166 in 399a683
| content.innerHTML = expanded |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 169 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace module with ⏎················(module)
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 171 in 399a683
| import('@spectrum-web-components/overlay/sp-overlay.js').then(module => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 172 in 399a683
| (module as any).Overlay?.update(); |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 172 in 399a683
| (module as any).Overlay?.update(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace } with ····}⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 173 in 399a683
| }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 176 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 185 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 187 in 399a683
| trigger="dynamic-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 188 in 399a683
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 217 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 219 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 221 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="rapid-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="rapid-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 239 in 399a683
| <sp-overlay trigger="rapid-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Try·clicking·the·trigger·button·multiple·times·quickly. with ⏎····························Try·clicking·the·trigger·button·multiple·times⏎····························quickly.⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 242 in 399a683
| <p>Try clicking the trigger button multiple times quickly.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Try·this:</strong>·Click·the·button·multiple·times·as·fast·as·you·can.·The·overlay·system·automatically·handles·rapid·interactions·without·getting·stuck·or·creating·multiple·overlays. with ⏎····················<strong>Try·this:</strong>⏎····················Click·the·button·multiple·times·as·fast·as·you·can.·The⏎····················overlay·system·automatically·handles·rapid·interactions⏎····················without·getting·stuck·or·creating·multiple·overlays.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 248 in 399a683
| <p><strong>Try this:</strong> Click the button multiple times as fast as you can. The overlay system automatically handles rapid interactions without getting stuck or creating multiple overlays.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 265 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 267 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 269 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="first-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="first-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 281 in 399a683
| <sp-overlay trigger="first-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Open·Second·Overlay with ⏎····························Open·Second·Overlay⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 285 in 399a683
| <sp-button id="second-trigger">Open Second Overlay</sp-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="second-trigger@click"·type="auto"·placement="right" with ⏎····························trigger="second-trigger@click"⏎····························type="auto"⏎····························placement="right"⏎························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 286 in 399a683
| <sp-overlay trigger="second-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Open·Third·Overlay with ⏎········································Open·Third·Overlay⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 290 in 399a683
| <sp-button id="third-trigger">Open Third Overlay</sp-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="third-trigger@click"·type="auto"·placement="right" with ⏎········································trigger="third-trigger@click"⏎········································type="auto"⏎········································placement="right"⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 291 in 399a683
| <sp-overlay trigger="third-trigger@click" type="auto" placement="right"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Third·overlay·(highest·in·stack) with ⏎····················································Third·overlay·(highest·in⏎····················································stack)⏎················································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 294 in 399a683
| <p>Third overlay (highest in stack)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Press·ESC·to·close·overlays·in·order with ⏎····················································Press·ESC·to·close·overlays⏎····················································in·order⏎················································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 295 in 399a683
| <p>Press ESC to close overlays in order</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 320 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 322 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 324 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="long-trigger@click"·type="auto"·placement="bottom" with ⏎················trigger="long-trigger@click"⏎················type="auto"⏎················placement="bottom"⏎············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 339 in 399a683
| <sp-overlay trigger="long-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace .fill(0).map( with ⏎································.fill(0)⏎································.map(⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 344 in 399a683
| ${Array(20).fill(0).map((_, i) => html` |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 345 in 399a683
| <p>Content paragraph ${i + 1}</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ``` with ········⏎································`
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 346 in 399a683
| `)} |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 366 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 368 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 370 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Responsive·behavior:</strong>·On·small·screens,·use·type="page"·for·full-screen·overlays·that·are·easier·to·interact·with. with ⏎····················<strong>Responsive·behavior:</strong>⏎····················On·small·screens,·use·type="page"·for·full-screen·overlays⏎····················that·are·easier·to·interact·with.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 398 in 399a683
| <p><strong>Responsive behavior:</strong> On small screens, use type="page" for full-screen overlays that are easier to interact with.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="mobile-trigger@click"·type="page"·placement="bottom" with ⏎····················trigger="mobile-trigger@click"⏎····················type="page"⏎····················placement="bottom"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 403 in 399a683
| <sp-overlay trigger="mobile-trigger@click" type="page" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace On·mobile,·overlays·can·take·full·screen·for·better·usability. with ⏎································On·mobile,·overlays·can·take·full·screen·for⏎································better·usability.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 407 in 399a683
| <p>On mobile, overlays can take full screen for better usability.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 432 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 434 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 436 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Clipping·workaround:</strong>·Even·though·the·parent·has·overflow:hidden,·the·overlay·renders·correctly·because·it's·placed·in·a·top-level·container. with ⏎····················<strong>Clipping·workaround:</strong>⏎····················Even·though·the·parent·has·overflow:hidden,·the·overlay⏎····················renders·correctly·because·it's·placed·in·a·top-level⏎····················container.⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 459 in 399a683
| <p><strong>Clipping workaround:</strong> Even though the parent has overflow:hidden, the overlay renders correctly because it's placed in a top-level container.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="clip-trigger@click"·type="auto"·placement="bottom" with ⏎····················trigger="clip-trigger@click"⏎····················type="auto"⏎····················placement="bottom"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-edge-cases.stories.ts
Line 464 in 399a683
| <sp-overlay trigger="clip-trigger@click" type="auto" placement="bottom"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 38 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 40 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 46 in 399a683
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 50 in 399a683
| const validateEmail = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 52 in 399a683
| const overlay = document.querySelector('#email-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 54 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 58 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 74 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 79 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 110 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 112 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 117 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 142 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·id="password-help"·variant="secondary"·size="m"·quiet with ⏎····················id="password-help"⏎····················variant="secondary"⏎····················size="m"⏎····················quiet⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 148 in 399a683
| <sp-button id="password-help" variant="secondary" size="m" quiet> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 151 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Contains·uppercase·and·lowercase·letters with ⏎····································Contains·uppercase·and·lowercase·letters⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 161 in 399a683
| <li>Contains uppercase and lowercase letters</li> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Contains·at·least·one·special·character·(!@#$%^&*) with ⏎····································Contains·at·least·one·special·character⏎····································(!@#$%^&*)⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 163 in 399a683
| <li>Contains at least one special character (!@#$%^&*)</li> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 184 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 186 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 191 in 399a683
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 195 in 399a683
| const validateUsername = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 197 in 399a683
| const overlay = document.querySelector('#username-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 199 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 203 in 399a683
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 204 in 399a683
| const validatePassword = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 206 in 399a683
| const overlay = document.querySelector('#password-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 208 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 212 in 399a683
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 213 in 399a683
| const validateConfirm = (event: Event) => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 215 in 399a683
| const overlay = document.querySelector('#confirm-error') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace '#password-field-multi' with ⏎············'#password-field-multi'⏎········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 216 in 399a683
| const passwordField = document.querySelector('#password-field-multi') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 216 in 399a683
| const passwordField = document.querySelector('#password-field-multi') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 218 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 222 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 235 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 240 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 245 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Username·must·be·at·least·3·characters·and·contain·only·letters,·numbers,·and·underscores with ⏎································Username·must·be·at·least·3·characters·and⏎································contain·only·letters,·numbers,·and·underscores⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 253 in 399a683
| <p>Username must be at least 3 characters and contain only letters, numbers, and underscores</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 258 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 263 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 269 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 282 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 287 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 293 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 306 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 323 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 325 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 330 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 346 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Country⏎················ with Country
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Lines 348 to 350 in 399a683
| <sp-field-label for="country-picker"> | |
| Country | |
| </sp-field-label> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 362 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Time·zone⏎················ with Time·zone
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Lines 364 to 366 in 399a683
| <sp-field-label for="timezone-picker"> | |
| Time zone | |
| </sp-field-label> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Pacific·Standard·Time·(PST) with ⏎························Pacific·Standard·Time·(PST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 368 in 399a683
| <sp-menu-item value="pst">Pacific Standard Time (PST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Mountain·Standard·Time·(MST) with ⏎························Mountain·Standard·Time·(MST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 369 in 399a683
| <sp-menu-item value="mst">Mountain Standard Time (MST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Central·Standard·Time·(CST) with ⏎························Central·Standard·Time·(CST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 370 in 399a683
| <sp-menu-item value="cst">Central Standard Time (CST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Eastern·Standard·Time·(EST) with ⏎························Eastern·Standard·Time·(EST)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 371 in 399a683
| <sp-menu-item value="est">Eastern Standard Time (EST)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Coordinated·Universal·Time·(UTC) with ⏎························Coordinated·Universal·Time·(UTC)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 372 in 399a683
| <sp-menu-item value="utc">Coordinated Universal Time (UTC)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Greenwich·Mean·Time·(GMT) with ⏎························Greenwich·Mean·Time·(GMT)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 373 in 399a683
| <sp-menu-item value="gmt">Greenwich Mean Time (GMT)</sp-menu-item> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 391 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 393 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 398 in 399a683
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 402 in 399a683
| const handleSave = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 403 in 399a683
| const nameField = document.querySelector('#edit-name-field') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 404 in 399a683
| const emailField = document.querySelector('#edit-email-field') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 405 in 399a683
| const display = document.querySelector('#user-info-display') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 406 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 413 in 399a683
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 414 in 399a683
| const overlay = document.querySelector('#edit-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 417 in 399a683
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 418 in 399a683
| const handleCancel = () => { |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 419 in 399a683
| const overlay = document.querySelector('#edit-overlay') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 422 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <br with ⏎····················<br·/
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 448 in 399a683
| <strong>John Doe</strong><br> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 454 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 466 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ···························· with ⏎····························<sp-field-label
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 470 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····························<sp-field-label·for="edit-email-field"·style="margin-top:·15px;" with ································for="edit-email-field"⏎································style="margin-top:·15px;"⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 471 in 399a683
| <sp-field-label for="edit-email-field" style="margin-top: 15px;"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 474 in 399a683
| <sp-textfield |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 478 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·variant="secondary"·@click=${handleCancel} with ⏎····································variant="secondary"⏎····································@click=${handleCancel}⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 480 in 399a683
| <sp-button variant="secondary" @click=${handleCancel}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·variant="accent"·@click=${handleSave} with ⏎····································variant="accent"⏎····································@click=${handleSave}⏎································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-form-patterns.stories.ts
Line 483 in 399a683
| <sp-button variant="accent" @click=${handleSave}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····openOverlay,⏎····VirtualTrigger,⏎ with ·openOverlay,·VirtualTrigger·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 23 to 26 in 399a683
| import { | |
| openOverlay, | |
| VirtualTrigger, | |
| } from '@spectrum-web-components/overlay'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 98 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 100 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 102 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················Save⏎················ with Save
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 110 to 112 in 399a683
| <sp-action-button id="tooltip-example"> | |
| Save | |
| </sp-action-button> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 113 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 114 in 399a683
| trigger="tooltip-example@hover" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 115 in 399a683
| type="hint" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>trigger</code>·attribute·connects·the·tooltip·to·your·button⏎····················using·the·button's·ID.·The·<code>@hover</code> with ⏎····················<code>trigger</code>⏎····················attribute·connects·the·tooltip·to·your·button·using·the⏎····················button's·ID.·The⏎····················<code>@hover</code>⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 126 to 127 in 399a683
| The <code>trigger</code> attribute connects the tooltip to your button | |
| using the button's ID. The <code>@hover</code> part tells it to show on hover. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Hover·over·the·Save·button·above</p> with ⏎····················👆·Try·it:·Hover·over·the·Save·button·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 129 in 399a683
| <p class="try-it">👆 Try it: Hover over the Save button above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 130 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>trigger:</strong>·Connects·to·button·using·"id@interaction" with ⏎····················•⏎····················<strong>trigger:</strong>⏎····················Connects·to·button·using·"id@interaction"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 146 in 399a683
| <p>• <strong>trigger:</strong> Connects to button using "id@interaction"</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="hint":</strong>·Non-blocking,·won't·interfere·with·page with ⏎····················•⏎····················<strong>type="hint":</strong>⏎····················Non-blocking,·won't·interfere·with·page⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 147 in 399a683
| <p>• <strong>type="hint":</strong> Non-blocking, won't interfere with page</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>placement:</strong>·Where·tooltip·appears·(top,·bottom,·left,·right) with ⏎····················•⏎····················<strong>placement:</strong>⏎····················Where·tooltip·appears·(top,·bottom,·left,·right)⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 148 in 399a683
| <p>• <strong>placement:</strong> Where tooltip appears (top, bottom, left, right)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>delayed:</strong>·Small·delay·before·showing·(better·UX) with ⏎····················•⏎····················<strong>delayed:</strong>⏎····················Small·delay·before·showing·(better·UX)⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 149 in 399a683
| <p>• <strong>delayed:</strong> Small delay before showing (better UX)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 161 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 163 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 165 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 176 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 177 in 399a683
| trigger="popover-example@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 178 in 399a683
| type="auto" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace This·is·a·simple·popover·with·some·helpful·information. with ⏎································This·is·a·simple·popover·with·some·helpful⏎································information.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 184 in 399a683
| <p>This is a simple popover with some helpful information.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>@click</code>·instead·of·<code>@hover</code>. with ⏎····················<code>@click</code>⏎····················instead·of⏎····················<code>@hover</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 194 in 399a683
| Similar to tooltips, but uses <code>@click</code> instead of <code>@hover</code>. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·The·popover·automatically·closes·when·you·click·outside·or with ·.·The·popover·automatically·closes·when·you·click·outside·or⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 195 in 399a683
| The popover automatically closes when you click outside or press Escape. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Click·the·"Show·Details"·button·above</p> with ⏎····················👆·Try·it:·Click·the·"Show·Details"·button·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 197 in 399a683
| <p class="try-it">👆 Try it: Click the "Show Details" button above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 198 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>@click:</strong>·Opens·on·button·click with ⏎····················•⏎····················<strong>@click:</strong>⏎····················Opens·on·button·click⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 218 in 399a683
| <p>• <strong>@click:</strong> Opens on button click</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="auto":</strong>·Closes·when·clicking·outside with ⏎····················•⏎····················<strong>type="auto":</strong>⏎····················Closes·when·clicking·outside⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 219 in 399a683
| <p>• <strong>type="auto":</strong> Closes when clicking outside</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-popover:</strong>·Container·for·popover·content with ⏎····················•⏎····················<strong>sp-popover:</strong>⏎····················Container·for·popover·content⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 220 in 399a683
| <p>• <strong>sp-popover:</strong> Container for popover content</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-dialog:</strong>·Provides·consistent·spacing·and·styling with ⏎····················•⏎····················<strong>sp-dialog:</strong>⏎····················Provides·consistent·spacing·and·styling⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 221 in 399a683
| <p>• <strong>sp-dialog:</strong> Provides consistent spacing and styling</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 233 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 235 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 237 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················trigger="modal-example@click"·⏎····················type="modal"⏎················ with trigger="modal-example@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Lines 248 to 251 in 399a683
| <sp-overlay | |
| trigger="modal-example@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-overlay[trigger="modal-example@click"]' with ⏎································'sp-overlay[trigger="modal-example@click"]'⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 259 in 399a683
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 259 in 399a683
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-overlay[trigger="modal-example@click"]' with ⏎································'sp-overlay[trigger="modal-example@click"]'⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 263 in 399a683
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <@typescript-eslint/no-explicit-any> reported by reviewdog 🐶
Unexpected any. Specify a different type.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 263 in 399a683
| const overlay = document.querySelector('sp-overlay[trigger="modal-example@click"]') as any; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·The·underlay·dims
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 275 in 399a683
| Modal dialogs block interaction with the page until closed. The underlay dims |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·the·background·to·focus·attention.·Use·<code>sp-dialog-wrapper</code>·for with ·The·underlay·dims·the·background·to·focus·attention.·Use⏎····················<code>sp-dialog-wrapper</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 276 in 399a683
| the background to focus attention. Use <code>sp-dialog-wrapper</code> for |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·for
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 277 in 399a683
| built-in action buttons. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Click·"Delete·Item"·to·see·the·modal</p> with ⏎····················👆·Try·it:·Click·"Delete·Item"·to·see·the·modal
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 279 in 399a683
| <p class="try-it">👆 Try it: Click "Delete Item" to see the modal</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 280 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>type="modal":</strong>·Blocks·page·interaction with ⏎····················•⏎····················<strong>type="modal":</strong>⏎····················Blocks·page·interaction⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 303 in 399a683
| <p>• <strong>type="modal":</strong> Blocks page interaction</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>underlay:</strong>·Dims·background with ⏎····················•⏎····················<strong>underlay:</strong>⏎····················Dims·background⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 304 in 399a683
| <p>• <strong>underlay:</strong> Dims background</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>sp-dialog-wrapper:</strong>·Provides·action·buttons with ⏎····················•⏎····················<strong>sp-dialog-wrapper:</strong>⏎····················Provides·action·buttons⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 305 in 399a683
| <p>• <strong>sp-dialog-wrapper:</strong> Provides action buttons</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>@confirm/@cancel:</strong>·Handle·button·clicks with ⏎····················•⏎····················<strong>@confirm/@cancel:</strong>⏎····················Handle·button·clicks⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 306 in 399a683
| <p>• <strong>@confirm/@cancel:</strong> Handle button clicks</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 318 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 320 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 322 in 399a683
| * |
Missing return type on function.
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 326 in 399a683
| const handleContextMenu = async (event: MouseEvent) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 328 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 332 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 344 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 347 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 355 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 358 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'sp-closed', with ⏎············'sp-closed',⏎···········
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 360 in 399a683
| overlay.addEventListener('sp-closed', () => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 361 in 399a683
| overlay.remove(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace },·{·once:·true·}); with ····},⏎············{·once:·true·}
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 362 in 399a683
| }, { once: true }); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert );⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 363 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 369 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 374 in 399a683
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;" with ⏎························style="margin:·0;·color:·var(--spectrum-gray-800);·font-weight:·bold;"⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 386 in 399a683
| <p style="margin: 0; color: var(--spectrum-gray-800); font-weight: bold;"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·<code>VirtualTrigger</code>·to with ⏎····················<code>VirtualTrigger</code>
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 395 in 399a683
| Context menus use the imperative API with <code>VirtualTrigger</code> to |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·position·the·menu·at·the·cursor.·This·requires·more·code·but·gives·you with ·to·position·the·menu·at·the·cursor.·This·requires·more·code
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 396 in 399a683
| position the menu at the cursor. This requires more code but gives you |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·but·gives·you
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 397 in 399a683
| full control. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 👆·Try·it:·Right-click·in·the·shaded·area·above</p> with ⏎····················👆·Try·it:·Right-click·in·the·shaded·area·above
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 399 in 399a683
| <p class="try-it">👆 Try it: Right-click in the shaded area above</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </p>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 400 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>VirtualTrigger:</strong>·Position·at·cursor·coordinates with ⏎····················•⏎····················<strong>VirtualTrigger:</strong>⏎····················Position·at·cursor·coordinates⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 432 in 399a683
| <p>• <strong>VirtualTrigger:</strong> Position at cursor coordinates</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>openOverlay():</strong>·Programmatic·API·for·advanced·control with ⏎····················•⏎····················<strong>openOverlay():</strong>⏎····················Programmatic·API·for·advanced·control⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 433 in 399a683
| <p>• <strong>openOverlay():</strong> Programmatic API for advanced control</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>event.preventDefault():</strong>·Suppress·browser·context·menu with ⏎····················•⏎····················<strong>event.preventDefault():</strong>⏎····················Suppress·browser·context·menu⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 434 in 399a683
| <p>• <strong>event.preventDefault():</strong> Suppress browser context menu</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace •·<strong>notImmediatelyClosable:</strong>·Prevents·instant·closing·on·right-click with ⏎····················•⏎····················<strong>notImmediatelyClosable:</strong>⏎····················Prevents·instant·closing·on·right-click⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 435 in 399a683
| <p>• <strong>notImmediatelyClosable:</strong> Prevents instant closing on right-click</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 447 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·menus,
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 495 in 399a683
| See real-world examples of validation popovers, action menus, |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ·menus,
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 496 in 399a683
| help systems, and more with complete code samples. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 498 in 399a683
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 499 in 399a683
| window.location.hash = '#overlay-patterns-examples-common-patterns--tooltip-pattern'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 500 in 399a683
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·available
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 508 in 399a683
| Dive deep into all the options, attributes, and events available |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·for·sp-overlay,·overlay-trigger,·and·the·trigger() with ·available·for·sp-overlay,·overlay-trigger,·and·the·trigger()⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 509 in 399a683
| for sp-overlay, overlay-trigger, and the trigger() directive. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 511 in 399a683
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 512 in 399a683
| window.location.hash = '#overlay-api-reference-sp-overlay--modal'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 513 in 399a683
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 524 in 399a683
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 525 in 399a683
| window.location.hash = '#overlay-edge-cases-troubleshooting-edge-cases--nested-scrolling'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 526 in 399a683
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 537 in 399a683
| <sp-link @click=${() => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ····················window.location.hash·= with ························window.location.hash·=⏎···························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 538 in 399a683
| window.location.hash = '#overlay-edge-cases-troubleshooting-troubleshooting--wont-open'; |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-quick-start.stories.ts
Line 539 in 399a683
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 86 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 88 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 90 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·The·button·ID·is·"correct-id"·but·the·overlay·is·looking·for with ⏎····················The·button·ID·is·"correct-id"·but·the·overlay·is·looking·for⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 108 in 399a683
| <strong>Problem:</strong> The button ID is "correct-id" but the overlay is looking for "wrong-id". |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 113 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 125 in 399a683
| <strong>Solution:</strong> Button ID matches the trigger attribute. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 145 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 147 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 149 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·type="inline"·doesn't·auto-close,·and·button·doesn't·trigger with ⏎····················type="inline"·doesn't·auto-close,·and·button·doesn't·trigger⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 168 in 399a683
| <strong>Problem:</strong> type="inline" doesn't auto-close, and button doesn't trigger close event. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 171 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎·······························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 179 in 399a683
| <sp-button @click=${(e: Event) => { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 179 in 399a683
| <sp-button @click=${(e: Event) => { |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace e.target?.dispatchEvent(new·Event('close',·{·bubbles:·true·}) with ····e.target?.dispatchEvent(⏎········································new·Event('close',·{·bubbles:·true·})⏎····································
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 180 in 399a683
| e.target?.dispatchEvent(new Event('close', { bubbles: true })); |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 180 in 399a683
| e.target?.dispatchEvent(new Event('close', { bubbles: true })); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace }} with ····}}⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 181 in 399a683
| }}> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 188 in 399a683
| <strong>Solution:</strong> Button dispatches 'close' event that bubbles to overlay. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 211 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 213 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 215 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Placement·defaults·to·'top'·which·might·not·be·what·you·want. with ⏎································Placement·defaults·to·'top'·which·might·not·be⏎································what·you·want.⏎····························
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 228 in 399a683
| <p>Placement defaults to 'top' which might not be what you want.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 233 in 399a683
| <strong>Problem:</strong> No placement specified, uses default. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 236 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·trigger="with-placement-trigger@click"·type="auto"·placement="bottom-start" with ⏎····················trigger="with-placement-trigger@click"⏎····················type="auto"⏎····················placement="bottom-start"⏎················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 240 in 399a683
| <sp-overlay trigger="with-placement-trigger@click" type="auto" placement="bottom-start"> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 248 in 399a683
| <strong>Solution:</strong> Specify placement explicitly. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Options:</strong>·top,·bottom,·left,·right·(with·-start/-end·variants) with ⏎························<strong>Options:</strong>⏎························top,·bottom,·left,·right·(with·-start/-end·variants)⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 250 in 399a683
| <p><strong>Options:</strong> top, bottom, left, right (with -start/-end variants)</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 268 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 270 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 272 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 282 in 399a683
| <sp-overlay |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 283 in 399a683
| trigger="no-focus-trigger@click" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·Modal·overlay·should·receive·focus·but with ⏎····················Modal·overlay·should·receive·focus·but⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 295 in 399a683
| <strong>Problem:</strong> Modal overlay should receive focus but receives-focus="false" disables it. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 298 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····················trigger="with-focus-trigger@click"·⏎····················type="modal"⏎················ with trigger="with-focus-trigger@click"·type="modal"
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Lines 302 to 305 in 399a683
| <sp-overlay | |
| trigger="with-focus-trigger@click" | |
| type="modal" | |
| > |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·Remove·receives-focus="false"·or·set·to·"auto"·for·default with ⏎····················Remove·receives-focus="false"·or·set·to·"auto"·for·default⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 314 in 399a683
| <strong>Solution:</strong> Remove receives-focus="false" or set to "auto" for default behavior. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 334 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 336 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 338 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎····························Popover⏎························ with Popover
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Lines 353 to 355 in 399a683
| <sp-dialog size="s" no-divider> | |
| Popover | |
| </sp-dialog> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 359 in 399a683
| <strong>Problem:</strong> Multiple sp-overlay elements can conflict. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 362 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 377 in 399a683
| <strong>Solution:</strong> Use overlay-trigger for multiple interactions. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 399 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 401 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 403 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Problem:</strong>·With·many·overlays,·all·content·is·in·DOM: with ⏎························<strong>Problem:</strong>⏎························With·many·overlays,·all·content·is·in·DOM:⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 413 in 399a683
| <p><strong>Problem:</strong> With many overlays, all content is in DOM:</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Result:·100·popovers·×·200·nodes·=·<strong>20,000·DOM·nodes</strong></p with ⏎························Result:·100·popovers·×·200·nodes·=⏎························<strong>20,000·DOM·nodes</strong
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 422 in 399a683
| <p>Result: 100 popovers × 200 nodes = <strong>20,000 DOM nodes</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace </div with ····</p
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 423 in 399a683
| </div> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ····
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 424 in 399a683
| </div> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert </div>⏎
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 425 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace <strong>Solution:</strong>·Use·slottable-request·to·load·content·on·demand: with ⏎························<strong>Solution:</strong>⏎························Use·slottable-request·to·load·content·on·demand:⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 429 in 399a683
| <p><strong>Solution:</strong> Use slottable-request to load content on demand:</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace Result:·Only·1-2·active·overlays·=·<strong>200-400·DOM·nodes</strong> with ⏎························Result:·Only·1-2·active·overlays·=⏎························<strong>200-400·DOM·nodes</strong>⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 443 in 399a683
| <p>Result: Only 1-2 active overlays = <strong>200-400 DOM nodes</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 💡·<strong>90%·reduction·in·memory!</strong> with ⏎························💡⏎························<strong>90%·reduction·in·memory!</strong>⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 444 in 399a683
| <p>💡 <strong>90% reduction in memory!</strong></p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 462 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 464 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 466 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 475 in 399a683
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 476 in 399a683
| id="div-trigger-wrong" |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 489 in 399a683
| <strong>Problem:</strong> Div element can't receive keyboard focus. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ············
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 493 in 399a683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 496 in 399a683
| <div |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 497 in 399a683
| id="div-trigger-fixed" |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 501 in 399a683
| @keydown=${(e: KeyboardEvent) => { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 502 in 399a683
| if (e.key === 'Enter' || e.key === ' ') { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 502 in 399a683
| if (e.key === 'Enter' || e.key === ' ') { |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 503 in 399a683
| e.preventDefault(); |
🚫 [eslint] <@spectrum-web-components/prevent-argument-names> reported by reviewdog 🐶
"e" shouldn't be used as an argument name
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 504 in 399a683
| (e.target as HTMLElement).click(); |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎···················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 518 in 399a683
| <strong>Solution:</strong> Add tabindex, role, and keyboard handler. |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 💡·<strong>Better:</strong>·Use·sp-button·for·built-in·accessibility. with ⏎························💡⏎························<strong>Better:</strong>⏎························Use·sp-button·for·built-in·accessibility.⏎····················
spectrum-web-components/1st-gen/packages/overlay/stories/overlay-troubleshooting.stories.ts
Line 524 in 399a683
| <p>💡 <strong>Better:</strong> Use sp-button for built-in accessibility.</p> |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
spectrum-web-components/1st-gen/packages/overlay/stories/utilities/story-helpers.ts
Line 27 in 399a683
| * |
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·
| * 📖 [Imperative API Guide](./imperative-api.md#virtualtrigger-patterns) | ||
| */ | ||
| export const VirtualPositioning = (): TemplateResult => { | ||
| const handleClick = async (event: MouseEvent) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return type on function.
| // Remove any existing overlays. | ||
| const existing = document.querySelector('.virtual-position-overlay'); | ||
| if (existing) existing.remove(); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
| <p>This overlay is positioned exactly where you clicked.</p> | ||
| </sp-dialog> | ||
| `; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
|
|
||
| // Position at click coordinates. | ||
| const trigger = new VirtualTrigger(event.clientX, event.clientY); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
| placement: 'bottom-start', | ||
| type: 'auto', | ||
| }); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ········
| */ | ||
| export const ComplexModal = (): TemplateResult => { | ||
| let step = 1; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
| export const ComplexModal = (): TemplateResult => { | ||
| let step = 1; | ||
|
|
||
| const nextStep = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return type on function.
| step++; | ||
| updateContent(); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
| updateContent(); | ||
| }; | ||
|
|
||
| const prevStep = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return type on function.
| step--; | ||
| updateContent(); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ····
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Description
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review