Skip to content

feat(thumbnail): S2 migration - #6726

Draft
cdransf wants to merge 1 commit into
mainfrom
cdransf/s2-migration-thumbnail
Draft

cdransf wants to merge 1 commit into
mainfrom
cdransf/s2-migration-thumbnail

Conversation

@cdransf

@cdransf cdransf commented Sep 9, 2026

Copy link
Copy Markdown
Member

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

@cdransf cdransf self-assigned this Sep 9, 2026
@cdransf cdransf added Status:WIP PR is a work in progress or draft Spectrum 2 Issues related to Spectrum 2 skip_vrt Skip VRT build; mark UI Tests green without running Chromatic labels Sep 9, 2026
@changeset-bot

changeset-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6ff19d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf
cdransf added this pull request to stack #6727 September 9, 2026 17:27
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6726

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@cdransf
cdransf removed this pull request from stack #6727 September 10, 2026 16:11
@cdransf
cdransf added this pull request to stack #6730 September 10, 2026 16:16
* chore(thumbnail): add s2 migration plan

* fix(thumbnail): address feedback

* fix(thumbnail): address feedback

* chore(thumbnail): minor language cleanup

* chore(thumbnail): add 2nd-gen file structure and stub component

* fix(thumbnail): address feedback
@cdransf
cdransf force-pushed the cdransf/s2-migration-thumbnail branch from 6443ed1 to 6ff19d8 Compare September 14, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip_vrt Skip VRT build; mark UI Tests green without running Chromatic Spectrum 2 Issues related to Spectrum 2 Status:WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant