Conversation
|
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
5t3ph
left a comment
There was a problem hiding this comment.
A note that the merge base isn't quite correct so this is showing more than just the "full fidelity" related changes
4294aff to
c90d5a8
Compare
Coverage Report for CI Build 34908834099Warning No base build found for commit Coverage: 96.287%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
Description
thumbnail.cssto Spectrum 2 tokens: all 12 sizes, bordered frame (inset box-shadow),fit="cover"|"contain", forced-colors border overridespectrum-cssspectrum-twobranch +@adobe/spectrum-tokens; droppedlayer/background/disabled/focused/selectedper the migration plan (consumer-owned styling instead)aria-hiddencould get permanently stuck on<swc-thumbnail decorative>oncedecorativewas unsetaltDEBUG warning could log twice on first renderMotivation and context
Closes out Phase 5 (Styling) of the Thumbnail migration so it matches the S2 Figma spec pixel-for-pixel.
Related issue(s)
Screenshots (if appropriate)
Add Chromatic/Storybook screenshots here before requesting review — sizes, fit, forced-colors.
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
All 12 sizes render correctly
Thumbnail>Sizesin Storybfitbehaves correctlyThumbnail>Fitin Storyboocontainto letterbox the image,coverto crop and fill the boxDecorative toggle no longer gets stuck
decorative, "` in devtoolsdecorativearia-hiddento be goneDevice review
Accessibility testing checklist
Keyboard (required — document st
Thumbnail>Overviewin StorybookScreen reader (required — document steps below)
Thumbnail>Overviewwith V<img>to announce as an image with itsalttext as the namedecorativein the Playground