Skip to content

feat(user-card): full s2 migration - #6742

Draft
aramos-adobe wants to merge 2 commits into
mainfrom
aziz/user-card-migration
Draft

aramos-adobe wants to merge 2 commits into
mainfrom
aziz/user-card-migration

Conversation

@aramos-adobe

Copy link
Copy Markdown
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

aramos-adobe and others added 2 commits September 14, 2026 15:15
* feat(user-card): files, api, styling extend CardBase

* fix(user-card): updating xs avatar size to 100

* chore(user-card): keep it focused on files api and styling for now tests for next pr

* feat(user-card): update grid avatar layout and docs

* fix(usercard): fixing broken doc links

* Update 2nd-gen/packages/swc/components/user-card/user-card.css

Use border width token instead of hardcoded value

Co-authored-by: Stephanie Eckles <seckles@adobe.com>

---------

Co-authored-by: Stephanie Eckles <seckles@adobe.com>
@aramos-adobe aramos-adobe self-assigned this Sep 14, 2026
@aramos-adobe
aramos-adobe requested a review from a team as a code owner September 14, 2026 19:20
@aramos-adobe aramos-adobe added Status:WIP PR is a work in progress or draft Component:Card gen2 These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels Sep 14, 2026
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3996597

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aramos-adobe
aramos-adobe marked this pull request as draft September 14, 2026 19:21
@aramos-adobe aramos-adobe changed the title Aziz/user card migration feat(user-card): full s2 migration Sep 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6742

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@aramos-adobe
aramos-adobe added this pull request to stack #6744 September 14, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Card gen2 These issues or PRs map to our 2nd generation work to modernizing infrastructure. Status:WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant