feat: add option to allow dropping a directory and reading the contents #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this contribution. I'll try to review later this week |
Contributor
|
Hey @gilest, would you be willing to review, if we update this PR? |
Collaborator
Yes I'm open to reviewing it. From memory it looked ok but there's a bit of async-waterfall happening, probably unavoidable. Was curious about how in-demand this feature might be but it seems reasonable to include. We also have better tests and tooling now to experiment with a feature like this before merging. |
Author
|
I'll close this one since I recreated it based on the latest master changes so there are no more merge conflicts: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at resolving #2 , to support dropping folders.
We needed this for one of our clients, so I tried to add the option. It's a bit convoluted but the whole File and Directories web API is not so easy to use. Definitely open for ideas (and suggestions for better testing / documentation), but it would be great if we could add this to the package, for now we're publishing and using a forked version which works but is not ideal.
It also does use the non-standard
webkitGetAsEntryfile api but as said in this comment it is widely supported:#2 (comment)
https://caniuse.com/?search=webkitGetAsEntry