add-shopping-cart-a #13
Conversation
adrianbucur83
left a comment
adrianbucur83
left a comment
There was a problem hiding this comment.
Nice job overall, see comments
| //create ShoppingCart | ||
| @PostMapping | ||
| @ResponseStatus(HttpStatus.CREATED) | ||
| public void createShoppingCart(@RequestBody ShoppingCartDto shoppingCartDto){ |
| } | ||
|
|
||
| @GetMapping("/description/{description}") | ||
| public List<ShoppingCartReturnDto> getShoppingCartByDescription |
There was a problem hiding this comment.
shopping carts are a bit special, you kinda want to set a cookie on the users' browser to identify his shopping cart id so that every time he comes to your website he has the products already in the cart. Maybe you want to implement something like this
There was a problem hiding this comment.
also don't take long strings as path variables it use request param better or request body. it will make your urls like this:
| //update ShoppingCart | ||
| @PutMapping | ||
| @ResponseStatus(HttpStatus.NO_CONTENT) | ||
| public void updateShoppingCart(@RequestBody ShoppingCartUpdateDto shoppingCartUpdateDto){ |
| //@Data | ||
| //@Builder | ||
| @Entity | ||
| @Table(name="shopping_cart") |
|
|
||
| List<ShoppingCart> findByDescriptionProduct(String description); | ||
|
|
||
| @Query(value="SELECT * FROM public.shopping_cart s WHERE s.description_product = :description", |
There was a problem hiding this comment.
nice mix of native and jpa queries, good job
| { | ||
| throw new RuntimeException("Delivery cannot be made on date specified"); | ||
| } | ||
| if (shoppingCartDto.getDescriptionProduct().length()<1) |
There was a problem hiding this comment.
you can use the the @Valid on the dto to check for min length and such
| public void create(ShoppingCartDto shoppingCartDto){ | ||
| if (!shoppingCartDto.isAvailability()) | ||
| { | ||
| throw new RuntimeException("Delivery is not available"); |
There was a problem hiding this comment.
define your own exception eg BusinessException and maybe an @ExceptionHandler too
No description provided.