Product reviews branch #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbucur83
requested changes
May 6, 2024
Owner
adrianbucur83
left a comment
adrianbucur83
left a comment
There was a problem hiding this comment.
Missing the controller and views
| <artifactId>spring-boot-starter-thymeleaf</artifactId> | ||
| <version>3.2.4</version> | ||
| </dependency> | ||
| <dependency> |
Owner
There was a problem hiding this comment.
we already have this in the project
| <!-- https://mvnrepository.com/artifact/org.springframework.boot/spring-boot-starter-data-jpa --> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-data-jpa</artifactId> |
| private LocalDateTime date; | ||
| private String userName; | ||
|
|
||
| public Review() { |
|
|
||
| @Data | ||
| public class ReviewDto { | ||
| private String reviewMsg; |
Owner
There was a problem hiding this comment.
these fields should be validated (maybe @NotNull or minimum size?)
| import java.time.LocalDateTime; | ||
|
|
||
| @Data | ||
| public class ReviewUpdateDto { |
| language=not set | ||
| numbers.separator=n | ||
|
|
||
| logging.level.root=info |
Owner
There was a problem hiding this comment.
don't commit this file :) git rm --cached
| public interface ReviewsRepository extends JpaRepository<Review, Integer> { | ||
| List<Review> getAllByUser(String userName); | ||
|
|
||
| void deleteAllByUser(String userName); |
Owner
There was a problem hiding this comment.
deleteAllByUser_name or something similar will work but you need to have the OneToOne/ OneToMany relation set up correctly
| private LocalDate date; | ||
|
|
||
| private LocalDateTime date; | ||
| private String userName; |
Owner
There was a problem hiding this comment.
This should be a User entrity and a relation like ManyToOne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviews repository and Dto files created