Add sensitive exposure split query #207
Open
+87
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we rename the |
|
|
||
| ## Examples | ||
|
|
||
| This CAP service directly logs the sensitive information. |
There was a problem hiding this comment.
Can you add more details to how this vulnerability can be exploited?
|
|
||
| ## Recommendation | ||
|
|
||
| CAP applications should not log sensitive information. |
There was a problem hiding this comment.
I think it'd be great to add some examples of sensitive information and ways to mitigate it.
Comment on lines
+23
to
+25
| override predicate isSource(DataFlow::Node source) { source instanceof CleartextLogging::Source } | ||
|
|
||
| override predicate isSink(DataFlow::Node sink) { sink instanceof CdsLogSink } |
There was a problem hiding this comment.
Add an appropriate sanitizer definition (either from CAP or predefined) and add a test case that uses such sanitizer.
jeongsoolee09
requested changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
js/cap-sensitive-logquery (to avoid duplications) but does use the CAP specific sinks and therefore also avoids duplication of alerts with the out of the box query.Future Works
none at this time