vulkan-validation-layers+vulkan-utility-libraries: Add at v1.4.357.0 - #2143
Open
cuddleworks wants to merge 2 commits into
Open
vulkan-validation-layers+vulkan-utility-libraries: Add at v1.4.357.0#2143cuddleworks wants to merge 2 commits into
cuddleworks wants to merge 2 commits into
Conversation
3 tasks
Jaredy899
requested changes
Aug 16, 2026
Member
|
@cuddleworks ^ please see Jared's review notes and address them. =) |
Author
|
will get to it once i get home (by tomorrow), currently travelling and I wouldn't be able to test if it builds and stuff |
cuddleworks
force-pushed
the
add-vulkan-validation-layers
branch
from
August 17, 2026 17:51
efbb035 to
2e942a7
Compare
Author
|
requested changes have been made (and tested) :3 |
Contributor
|
Seems okay to me. I'm going to have someone else verify me (especially as it ships with static libs). |
Member
|
@ReillyBrogan I'd be much obliged if you could take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
vulkan-validation-layersand its builddep,vulkan-utility-libraries. Resolves #2287.Test Plan
Ran
vkcube --validatewithout errors.If you run the same command without the layers installed, it throws an error (I also inspected the source code and it does use the
VK_LAYER_KHRONOS_validationlayer and check if it exists).Checklist