Skip to content

fcitx5-chinese-addons: Add at 5.1.13 - #2164

Open
K1ngfish3r wants to merge 9 commits into
aerynOS:mainfrom
K1ngfish3r:fcitx5-chinese
Open

fcitx5-chinese-addons: Add at 5.1.13#2164
K1ngfish3r wants to merge 9 commits into
aerynOS:mainfrom
K1ngfish3r:fcitx5-chinese

Conversation

@K1ngfish3r

@K1ngfish3r K1ngfish3r commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds the following packages

  • libime
  • marisa (bindings for various langs have been split)
  • darts (clone by s-yata)
  • limonp
  • cppjieba
  • tclap
  • opencc (not sure if should have separate python package or not, left as is)
  • fcitx5-lua
  • fcitx5-chinese-addons

Test Plan

technically not sure what implies a "good" test, i can type... i guess

Checklist

  • Recipe was built and tested against the volatile stream
  • This change could gainfully be highlighted in the Stream Update notes once merged

@K1ngfish3r
K1ngfish3r requested a review from a team as a code owner August 3, 2026 22:10
@K1ngfish3r
K1ngfish3r force-pushed the fcitx5-chinese branch 4 times, most recently from 89bc8fb to 4c6fe29 Compare August 4, 2026 00:01
@ermo

ermo commented Aug 5, 2026

Copy link
Copy Markdown
Member

@lumi-me-not @CookieSource This needs your input I think.

@lumi-me-not lumi-me-not left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, I don't know enough about the respective codebases to vet the patches very well, but doing a cursory look, it looks good to me. Just a little comment about a GitHub workflow being in the patch, but that shouldn't matter much.

Comment thread m/marisa/pkg/123.patch Outdated
@K1ngfish3r
K1ngfish3r force-pushed the fcitx5-chinese branch 2 times, most recently from 3f0e49a to ab874ab Compare August 7, 2026 17:01
@CookieSource

Copy link
Copy Markdown
Member

I took a peek but I also don't know much about the patches. I am aware the LUA stuff is required for some language dics to work. I should note that outside of Japanese I am not quite sure which ones are the best for other languages. https://wiki.archlinux.org/title/Input_method#List_of_available_input_method_editors I used the Arch page for context. Perhaps it would be wise to ask our Chinese speaking audience what input method works the best for them. I use fcitx5-mozc for Japanese (but asking a native person is still preferable) considering there's multiple choices that work with fcitx5

@ermo

ermo commented Aug 10, 2026

Copy link
Copy Markdown
Member

Are we supposed to merge this as-is for more testing?

@CookieSource

Copy link
Copy Markdown
Member

I think if typing the characters works lets merge it. Then people can test and we can fix potential issues.

@ermo

ermo commented Aug 11, 2026

Copy link
Copy Markdown
Member

I think if typing the characters works lets merge it. Then people can test and we can fix potential issues.

OK. Then I guess somebody will need to add a video showing that typing the characters works here before we merge.

@CookieSource

Copy link
Copy Markdown
Member

@K1ngfish3r Could you provide a quick vid that it works ?

@K1ngfish3r

Copy link
Copy Markdown
Contributor Author
  • removed a stray %break_exit in libime
  • fixed cppjieba release-monitoring id leading to another package
  • updated all packages to latest
chinese-addons_av1.mp4

Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants