fcitx5-chinese-addons: Add at 5.1.13 - #2164
Conversation
89bc8fb to
4c6fe29
Compare
|
@lumi-me-not @CookieSource This needs your input I think. |
lumi-me-not
left a comment
There was a problem hiding this comment.
Admittedly, I don't know enough about the respective codebases to vet the patches very well, but doing a cursory look, it looks good to me. Just a little comment about a GitHub workflow being in the patch, but that shouldn't matter much.
3f0e49a to
ab874ab
Compare
|
I took a peek but I also don't know much about the patches. I am aware the LUA stuff is required for some language dics to work. I should note that outside of Japanese I am not quite sure which ones are the best for other languages. https://wiki.archlinux.org/title/Input_method#List_of_available_input_method_editors I used the Arch page for context. Perhaps it would be wise to ask our Chinese speaking audience what input method works the best for them. I use fcitx5-mozc for Japanese (but asking a native person is still preferable) considering there's multiple choices that work with fcitx5 |
|
Are we supposed to merge this as-is for more testing? |
|
I think if typing the characters works lets merge it. Then people can test and we can fix potential issues. |
OK. Then I guess somebody will need to add a video showing that typing the characters works here before we merge. |
|
@K1ngfish3r Could you provide a quick vid that it works ? |
ab874ab to
7ccd982
Compare
chinese-addons_av1.mp4 |
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
Signed-off-by: K1ngfish3r <26593485+K1ngfish3r@users.noreply.github.com>
7ccd982 to
ee0f011
Compare
Summary
Adds the following packages
Test Plan
technically not sure what implies a "good" test, i can type... i guess
Checklist