Switch to new middleware, bug fixes and maintenance #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a bug in 3e29f3f
CedrikNikita
reviewed
Feb 7, 2022
src/pages/aens/NameList.vue
Outdated
| :key="bid.name" | ||
| :name="bid.name" | ||
| :balance="bid.nameFee" | ||
| :address="(bid.auction ?? bid.info).lastBid.tx.accountId" |
There was a problem hiding this comment.
despite that nullish coalescing doesn't seems to parse, but a lot of sdk files are using it which results in
Module parse failed: Unexpected token (87:44) You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file.
CedrikNikita
reviewed
Feb 7, 2022
| "test:e2e": "vue-cli-service test:e2e", | ||
| "test:unit": "vue-cli-service test:unit", | ||
| "i18n:report": "vue-i18n-extract report --vueFiles './src/**/*.?(js|vue)' --languageFiles './src/locales/**/*.json'" | ||
| }, | ||
| "dependencies": { | ||
| "@aeternity/aepp-sdk": "^8.1.0", | ||
| "@aeternity/aepp-sdk": "github:aeternity/aepp-sdk-js#develop", |
There was a problem hiding this comment.
I don't like an idea to depend from the develop branch.
Also the installed package from the develop branch doesn't have a lot of prebuild files inside es folder.
There was a problem hiding this comment.
this is not compatible with Windows, but it is the fastest way to make a release of Base aepp 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found issues:
aeternity/ae_mdw#503
aeternity/ae_mdw#508
aeternity/ae_mdw#509
aeternity/ae_mdw#510
aeternity/ae_mdw#511
aeternity/ae_mdw#512
aeternity/aeternity#3852
superhero-com/superhero-wallet#1400
aeternity/mdw-frontend#162
#1436
#1437
closes #1421