Skip to content

Fix LetsEncrypt breakage following discontinued support for sending expiration notifications #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasani72 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix LetsEncrypt breakage following discontinued support for sending expiration notifications #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ public function getAccount(): Account
$data = json_decode((string)$response->getBody(), true);
$accountURL = $response->getHeaderLine('Location');
$date = (new \DateTime())->setTimestamp(strtotime($data['createdAt']));
return new Account($data['contact'], $date, ($data['status'] == 'valid'), $accountURL);
return new Account($date, ($data['status'] == 'valid'), $accountURL);
}

/**
Expand Down
18 changes: 0 additions & 18 deletions src/Data/Account.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@

class Account
{

/**
* @var array
*/
protected $contact;

/**
* @var string
*/
Expand All @@ -28,18 +22,15 @@ class Account

/**
* Account constructor.
* @param array $contact
* @param \DateTime $createdAt
* @param bool $isValid
* @param string $accountURL
*/
public function __construct(
array $contact,
\DateTime $createdAt,
bool $isValid,
string $accountURL
) {
$this->contact = $contact;
$this->createdAt = $createdAt;
$this->isValid = $isValid;
$this->accountURL = $accountURL;
Expand Down Expand Up @@ -72,15 +63,6 @@ public function getAccountURL(): string
return $this->accountURL;
}

/**
* Return contact data
* @return array
*/
public function getContact(): array
{
return $this->contact;
}

/**
* Returns validation status
* @return bool
Expand Down