Logitech MX Ink improvements#5756
Merged
dmarcos merged 3 commits intoaframevr:masterfrom Sep 22, 2025
FilipeLopesPires:logitech-mx-ink-controls-improvements
Merged
Logitech MX Ink improvements#5756dmarcos merged 3 commits intoaframevr:masterfrom FilipeLopesPires:logitech-mx-ink-controls-improvements
dmarcos merged 3 commits intoaframevr:masterfrom
FilipeLopesPires:logitech-mx-ink-controls-improvements
Conversation
…gh / mixed reality).
…n based on button/tip pressure applied.
Contributor
Author
|
@dmarcos would you be the best PR reviewer for this? |
dmarcos
reviewed
Sep 9, 2025
| if (!this.data.enabled) { return; } | ||
| if (!this.painting) { return; } | ||
| if (evt.detail.state.value === 1) { | ||
| this.data.size = this.originalSize; |
Member
There was a problem hiding this comment.
don't modify the this.data.size It will be overridden if the component property changes. Have a this.sizeFactor variable that is applied below
this.stroke.setSize(this.data.size * this.sizeFactor)
Contributor
Author
There was a problem hiding this comment.
Nice catch. SizeFactor added, take a look when you get a chance. And thanks for the review!
Member
|
@FilipeLopesPires thanks for the patience. It's close. I left a comment. Thanks so much! |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Improvements to A-Frame's integration of Logitech's MX Ink Stylus
Changes proposed: