[ag-ui-adk] Fixes #907 Finegrained configuration of SessionManager #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplikesbikes
changed the title
contextablemark
requested changes
Jan 10, 2026
Collaborator
contextablemark
left a comment
contextablemark
left a comment
There was a problem hiding this comment.
@jplikesbikes Thank you for another great submission!
Besides the one comment, this one needs more tests, specifically :
-
There are tests for both flags false and both true in the "end of session" behavior, but needs to be tests for the two "mixed" combinations.
-
Additional cleanup loop tests for the same mixed settings as well as cleanup loop behavior with both set to false.
-
Test that flags make it through to agent._session_manager when either the direct
ADKAgentconstructor is used or whenADKAgent.from_appis used -
Edge case tests
- What happens when save session is true, but memory service is set to None?
- Verify that sessions with
pending_tool_callsare preserved even whendelete_session_on_cleanup=True
…on_to_memory_on_cleanup=True
…session_on_cleanup=True
contextablemark
approved these changes
Jan 13, 2026
Collaborator
contextablemark
left a comment
contextablemark
left a comment
There was a problem hiding this comment.
lgtm... will run e2e tests and merge
Collaborator
|
E2E tests confirmed with #928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements issue #907 it separates the concerns of deleting the session from the adk SessionService and adding the session to the MemoryService during session clean up in the SessionManager
It splits the
auto_cleanupparameter into two separate parametersdelete_session_on_cleanupandsave_session_to_memory_on_cleanupThese parameters are exposed when creating the ADKAgent