Dynamic sprites use in memory buffers #1130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corwinkuiper
commented
Jan 4, 2026
corwinkuiper
commented
- Changelog updated / no changelog update needed
corwinkuiper
force-pushed
the
dynamic-sprite-changes
branch
from
413e124 to
a063dd2
Compare
gwilymk
reviewed
Jan 4, 2026
|
|
||
| unsafe { | ||
| let dest = data.cast().as_ptr(); | ||
| crate::agbabi::memcpy_16(self.data.as_ptr().cast(), dest, self.data.len() * 2); |
Member
There was a problem hiding this comment.
I think you can still do 32-bit writes to vram, it's only 8-bit writes that go wrong. And I also believe it's always best to do the 32-bit writes where possible for performance
corwinkuiper
force-pushed
the
dynamic-sprite-changes
branch
from
5142b12 to
aa14847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.