-
Notifications
You must be signed in to change notification settings - Fork 251
Issue2788 #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.3-release
Are you sure you want to change the base?
Issue2788 #2794
Conversation
Thanks @JacquesCarette! Was hoping to make the release of v2.3 now, but I guess we need to wait for @jamesmckinna's approval for this. |
Review incoming, but as a placeholder
Re: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See placeholder comment, plus module-level suggestion.
CHANGELOG
comments to follow
I've only made |
Question: when/if this is merged into the |
Co-authored-by: jamesmckinna <[email protected]>
Co-authored-by: jamesmckinna <[email protected]>
If/when this gets merged, we'll have to cherry-pick it, somehow, back onto master and experimental. |
Co-authored-by: jamesmckinna <[email protected]>
This was indeed anachronistic from 2.0 Co-authored-by: jamesmckinna <[email protected]>
Co-authored-by: jamesmckinna <[email protected]>
Will re-review in the morning! |
This puts back everything that was mistakenly reverted -- closes #2788