Skip to content

Issue2788 #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: v2.3-release
Choose a base branch
from
Open

Issue2788 #2794

wants to merge 11 commits into from

Conversation

JacquesCarette
Copy link
Contributor

@JacquesCarette JacquesCarette commented Jul 30, 2025

This puts back everything that was mistakenly reverted -- closes #2788

@MatthewDaggitt MatthewDaggitt changed the base branch from v2.3-release to master July 30, 2025 23:58
@MatthewDaggitt MatthewDaggitt changed the base branch from master to v2.3-release July 30, 2025 23:58
@MatthewDaggitt
Copy link
Contributor

Thanks @JacquesCarette!

Was hoping to make the release of v2.3 now, but I guess we need to wait for @jamesmckinna's approval for this.

@MatthewDaggitt MatthewDaggitt added this to the v2.3 milestone Jul 31, 2025
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Jul 31, 2025

Review incoming, but as a placeholder
Re: the additions (x signifies approval):

  • Algebra.Construct.Flip.Op
  • Data.Fin.Properties
  • Data.Sum.Relation.Binary.LeftOrder looks good, but possible downstream refactoring wrt variables
  • Data.Sum.Relation.Binary.Pointwise has a spurious anonymous module declaration L111-L114, plus some weirdness in the comment/behaviour wrt variables in ⊎-wellFounded

Re: CHANGELOG
This is trickier, because of the 'anachronism's... will re-review shortly. My suggestions end up still leaving it in a not-completely consistent state!?

Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See placeholder comment, plus module-level suggestion.
CHANGELOG comments to follow

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Jul 31, 2025

I've only made suggestions... in case my commits make things worse! But CHANGELOG definitely needs fixing, and Pointwise could be (rational reconstruction) tweaked a little from the original, given all the time which has elapsed since the original PR...

@jamesmckinna jamesmckinna linked an issue Jul 31, 2025 that may be closed by this pull request
4 tasks
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Jul 31, 2025

Question: when/if this is merged into the release-2.3 branch, when/how do we also merge it into master? And what about experimental as well?

@jamesmckinna jamesmckinna mentioned this pull request Jul 31, 2025
JacquesCarette and others added 2 commits July 31, 2025 14:08
Co-authored-by: jamesmckinna <[email protected]>
Co-authored-by: jamesmckinna <[email protected]>
@JacquesCarette
Copy link
Contributor Author

If/when this gets merged, we'll have to cherry-pick it, somehow, back onto master and experimental.

JacquesCarette and others added 4 commits July 31, 2025 14:53
Co-authored-by: jamesmckinna <[email protected]>
This was indeed anachronistic from 2.0

Co-authored-by: jamesmckinna <[email protected]>
Co-authored-by: jamesmckinna <[email protected]>
@jamesmckinna
Copy link
Contributor

Will re-review in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ] missing commits from v2.0 onwards
5 participants