Adds additional properties to LeftModule #2906
Open
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmckinna
requested changes
Jan 8, 2026
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
Very nice addition, but I think the suggested renaming/refactorings make it 'better'?
(Open to debate on this, though! esp. with any 2nd reviewer...)
using suggestion Co-authored-by: jamesmckinna <[email protected]>
jamesmckinna
approved these changes
Jan 9, 2026
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
Looks great now! Thanks for the prompt response to my feedback.
Member
|
This is very good! But I'd like to see the corresponding proofs on right modules as well in this PR |
Collaborator
|
I agree with @Taneb regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional properties to
Algebra.Module.Properties.LeftModule.NOTE: I can also add the corresponding properties to
RightModule, but I'll wait for any discussions of naming and appropriateness of the LeftModule properties to conclude first.