Skip to content

fix: preserve selected AskUserQuestion option - #1054

Open
kocaemre wants to merge 1 commit into
agentclientprotocol:mainfrom
kocaemre:fix/ask-question-selected-option-notes
Open

fix: preserve selected AskUserQuestion option#1054
kocaemre wants to merge 1 commit into
agentclientprotocol:mainfrom
kocaemre:fix/ask-question-selected-option-notes

Conversation

@kocaemre

Copy link
Copy Markdown

Summary

  • Preserve the selected AskUserQuestion option when clients also return follow-up text
  • Keep free-form-only answers working when no option is selected
  • Add a regression test for the option + follow-up text case

Closes #1050

Test plan

  • npm run test:run -- src/tests/elicitation.test.ts
  • npm run build
  • npm run check
  • git diff --check

Full npm run test:run was also attempted; it reached 1042 passed / 27 skipped and failed only the existing root-environment resolvePermissionMode bypassPermissions expectations.

Signed-off-by: Emre Koca <110906681+kocaemre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting an option in a permission/question dialog is discarded — only the followup notes text is returned

1 participant