Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.9, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
Background
The unit test code
runSubscribeOnThenSequentialSecondCallStructuredOutputScenariocontains twoagent.callactions.The first thread's
agent.callwritesgenerate_responseinto the Toolkit and then clears it in thedoFinallyblock.The second thread's
agent.callalso writesgenerate_responseinto the Toolkit and then clears it in thedoFinallyblock.Problem
The issue occurs when the first thread executes
doFinallylater than the second thread writesgenerate_response. In this case, the first thread will clear the content written by the second thread into the Toolkit, causing the second thread to fail to retrievegenerate_response.Objective
Avoid "late cleanup" mistakenly deleting a tool with the same name that has already been overwritten by another call.
Implementation Approach
Use Java's
ConcurrentHashMap.remove(Object key, Object value)to ensure only the tool written by the current thread is removed, while preventing race conditions.How to Verify
Add a new test method:
io.agentscope.core.agent.ReActAgentStructuredOutputTest#testConcurrencyConflictStructuredOutput_repeated.Test the same method 25,000 times. If no exceptions occur, it can be considered basically problem-free.
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)