Repository navigation
ci: run every e2e job on a single kurtosis-cdk commit and allow an optional GCP identity for image pulls - #1977
Open
arnaubennassar wants to merge 4 commits into
Open
arnaubennassar wants to merge 4 commits into
arnaubennassar wants to merge 4 commits into
Conversation
Pin KURTOSIS_CDK_COMMIT to the kurtosis-cdk commit that has the AggOracle committee v2 (85fcdea) and use it for every e2e job, including the committee v2 job, so the second committee-only pin goes away. The nightly run uses the same pinned commit instead of following kurtosis-cdk main. Move every agglayer/e2e reference to a5e723b (main) and pass the optional gcp-workload-identity-provider / gcp-service-account inputs from the GCP_WORKLOAD_IDENTITY_PROVIDER and KURTOSIS_GCP_SERVICE_ACCOUNT repository variables. When they are not set the inputs are empty and kurtosis-pre-run keeps its default identity. Install kurtosis CLI 1.23.0 in the multi-chain workflow, the version that kurtosis-cdk expects at the pinned commit.
Contributor
Author
|
Claude finished @arnaubennassar's task in 28s —— View job Review of PR #1977
The change is small and consistent. I found no blocking issues. Findings🔴 Required: none. 🟡 Suggested
🟢 Optional
Things I checked
Summary template🚀 What's New
🐛 Bug Fixes
📋 Config Updates
|
joanestebanr
approved these changes
Nov 17, 2026
Contributor
Author
|
Thanks for the review. Summary of what was done with it:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KURTOSIS_CDK_COMMITnow points to85fcdea(the merge of feat(aggkit): add the AggOracleCommittee v2, with GER validators 0xPolygon/kurtosis-cdk#1044, which has the AggOracle committee v2). The committee v2 job takes it fromget-kurtosis-cdk-commitlike the other jobs, soKURTOSIS_CDK_COMMITTEE_V2_COMMITand thecommittee-v2-kurtosis-refoutput are removed.get-kurtosis-cdk-commitno longer switches to kurtosis-cdkmainonschedule; every event usesKURTOSIS_CDK_COMMIT. Moving to a newer kurtosis-cdk is an explicit bump of that one value.1.23.0(with its published SHA-256), the version kurtosis-cdk installs at the pinned commit (kurtosis-pre-rundefault and its own CI). The nightly run on kurtosis-cdkmainfailed the multi-chain jobs withCannot construct 'PortSpec'because CLI1.22.2did not match.a5e723b(main) everywhere, which adds the optionalgcp-workload-identity-provider/gcp-service-accountinputs of the single-chain workflow. The single-chain jobs pass them from theGCP_WORKLOAD_IDENTITY_PROVIDERandKURTOSIS_GCP_SERVICE_ACCOUNTrepository variables. When the variables are not set the inputs are empty andkurtosis-pre-runkeeps its default identity, so behaviour here does not change.Test plan
zizmor --min-severity medium .github/workflows(v1.32.0): no findingsactionlinton both workflows: cleanBats E2E Testsgreen on this branch: single-chain (OP pessimistic, op-succinct, AggOracle committee v2) and multi-chain (2 and 3 chains)