Reduce verbose transaction logging #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove noisy info-level logs for routine transaction operations (begin, commit, savepoint create/release). Keep rollback success logs at info level since those indicate something noteworthy happened. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR reduces verbosity in transaction logging by removing routine info-level logs while keeping notable events at info level. The changes specifically remove info-level success logs for normal transaction operations (begin, commit, savepoint create/release) and downgrade savepoint creation logs to debug level, while preserving info-level logging for rollback operations which indicate exceptional scenarios.
Key changes:
- Removed info-level success logs for transaction begin and commit operations
- Removed info-level success log for savepoint release operation
- Downgraded savepoint creation log from info to debug level
- Version bumped from 1.3.0 to 1.3.1
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mayim/transaction/coordinator.py | Removes info-level logs for transaction begin and commit success; downgrades savepoint creation log to debug level |
| src/mayim/transaction/savepoint.py | Removes info-level success log for savepoint release operation |
| setup.cfg | Bumps version from 1.3.0 to 1.3.1 to reflect the logging improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code