Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Use ldconfig -p | grep libmagic to discover Ubuntu libmagic #343

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 14, 2025

Let's get the macOS and Ubuntu tests passing again.

test/python_magic_test.py -- test_all_cases() seems to be a work in progress. Broken pytests belong in pull requests, not on master!

@ahupp Your review, please. The repo should have ci tests that pass.

@cclauss cclauss changed the title GitHub Actions: apt-get install -y libmagic-dev GitHub Actions: apt-get install -y libmagic1 Feb 14, 2025
@cclauss cclauss force-pushed the patch-1 branch 3 times, most recently from 56dce0f to 0e96333 Compare February 14, 2025 18:13
Let's get the Ubuntu tests passing again.
@cclauss cclauss changed the title GitHub Actions: apt-get install -y libmagic1 GitHub Actions: Use ldconfig -p | grep libmagic to discover Ubuntu libmagic Feb 14, 2025
@ahupp
Copy link
Owner

ahupp commented Feb 19, 2025

I'd like to use normal shared library lookup paths as much as possible, rather than hard-coding for specific distributions. Those kind of updates have been by volume the most common changes to this package over the years. I think the issue you're seeing is due to a broken merge I did a while back that is fixed in #346.

@ahupp
Copy link
Owner

ahupp commented Feb 19, 2025

re: adding a dependency on python-magic-bin, I'm not comfortable with that. The immediate issue is that it uses the same package name as python-magic but hasn't been updated forever, and depending on the specific ordering of things in pip the import magic will give you one version or another.

But also, it has binaries built from who knows what source by who knows what person, and I think given any binary I ship (or depend on) needs to be built out of github CI from a known-good source and uploaded directly from there.

@cclauss cclauss closed this Feb 19, 2025
@cclauss cclauss deleted the patch-1 branch February 19, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants