Optimize spans buffer insertion with eviction during insert #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the Redis buffer system to support dedicated queue routing for different models, improving performance isolation and reducing buffer processing contention across high-volume models. Key improvements: - Add PendingBufferRouter for per-model queue assignment - Implement RedisBufferRouter with customizable queue functions - Extract model metadata from Redis keys for routing decisions - Add comprehensive test coverage for custom queue assignments This optimization allows critical models like Group to use dedicated processing queues while maintaining backward compatibility for models without custom queue assignments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the Redis buffer system by implementing a router-based approach that allows different models to use dedicated queues for processing buffer increments. This prevents backlog issues with one model from affecting others.
- Introduces
RedisBufferRouterandPendingBufferRouterclasses to manage model-specific buffer routing - Replaces single shared
PendingBufferwith multiple model-specific buffers - Adds queue assignment functionality for models to use dedicated processing queues
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/sentry/buffer/redis.py | Core implementation of buffer routing system with new router classes and model key extraction |
| tests/sentry/buffer/test_redis.py | Updates imports to include new router functionality and helper functions |
| sentry-repo | Adds subproject commit reference |
| def __init__(self, incr_batch_size: int) -> None: | ||
| self.incr_batch_size = incr_batch_size | ||
| self.default_pending_buffer = PendingBuffer(self.incr_batch_size) | ||
| # map of model_key to PendingBufferValue |
There was a problem hiding this comment.
There is an extra trailing space at the end of the comment line.
Suggested change
| # map of model_key to PendingBufferValue | |
| # map of model_key to PendingBufferValue |
| self.incr_batch_size = incr_batch_size | ||
| self.default_pending_buffer = PendingBuffer(self.incr_batch_size) | ||
| # map of model_key to PendingBufferValue | ||
| self.pending_buffer_router: dict[str, PendingBufferValue] = dict() |
There was a problem hiding this comment.
[nitpick] Use {} instead of dict() for better performance and readability when creating empty dictionaries.
Suggested change
| self.pending_buffer_router: dict[str, PendingBufferValue] = dict() | |
| self.pending_buffer_router: dict[str, PendingBufferValue] = {} |
| class RedisBufferRouter: | ||
| def __init__(self) -> None: | ||
| # map of model_key (generated from _get_model_key function) to queue name | ||
| self._routers: dict[str, ChooseQueueFunction] = dict() |
There was a problem hiding this comment.
[nitpick] Use {} instead of dict() for better performance and readability when creating empty dictionaries.
Suggested change
| self._routers: dict[str, ChooseQueueFunction] = dict() | |
| self._routers: dict[str, ChooseQueueFunction] = {} |
| # | ||
| # Hence, we override the default queue of the process_incr task by passing in the assigned queue for the | ||
| # model associated with the model_key. | ||
| process_incr_kwargs: dict[str, Any] = dict() |
There was a problem hiding this comment.
[nitpick] Use {} instead of dict() for better performance and readability when creating empty dictionaries.
Suggested change
| process_incr_kwargs: dict[str, Any] = dict() | |
| process_incr_kwargs: dict[str, Any] = {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 2