Anonymous: Add configurable device limit #10
Conversation
* Anonymous: Add device limiter * break auth if limit reached * fix typo * refactored const to make it clearer with expiration * anon device limit for config --------- Co-authored-by: Eric Leijonmarck <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| err = a.tagDeviceUI(ctx, httpReq, taggedDevice) | ||
| if err != nil { | ||
| a.log.Debug("Failed to tag device for UI", "error", err) | ||
| return err |
There was a problem hiding this comment.
The new error propagation in TagDevice (lines 144‑147) means we now rely on tagDeviceUI failing with ErrDeviceLimitReached to block additional anonymous devices. However, tagDeviceUI still writes the device key into the local cache before it calls CreateOrUpdateDevice, and it never clears that entry when the store returns an error. As a result, when a new device first hits the limit the request fails once, but the cache entry remains for ~29 minutes and every subsequent request short‑circuits out of tagDeviceUI without touching the DB, so ErrDeviceLimitReached is never raised again and the same device is allowed to authenticate despite the configured limit. To actually enforce the limit you need to only cache after a successful store (or remove the cache entry when CreateOrUpdateDevice errors) so that each retry keeps hitting the limit check.
Useful? React with 👍 / 👎.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions! |
Test 1
Replicated from ai-code-review-evaluation/grafana-cursor#1