plugins/posix: minimized IO queue abstraction #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-nayshtut
requested review from
barneuman,
etoledano,
vvenkates27 and
w1ldptr
as code owners
|
👋 Hi anton-nayshtut! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
1aa9a5e to
a81c168
Compare
Signed-off-by: Anton Nayshtut <[email protected]>
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
a81c168 to
b665245
Compare
benlwalker
reviewed
Nov 24, 2025
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
b665245 to
be8fe2a
Compare
anton-nayshtut
changed the title
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
be8fe2a to
b607ba4
Compare
anton-nayshtut
changed the title
iyastreb
reviewed
Nov 26, 2025
src/plugins/posix/io_queue.h
Outdated
| } | ||
|
|
||
| protected: | ||
| static std::map<std::string, nixlPosixIOQueueCreateFn> apis; |
Contributor
There was a problem hiding this comment.
This class is implicit singleton, which is often considered as anti-pattern
Maybe these fields should not be static?
Contributor
Author
There was a problem hiding this comment.
For now, I replaced it by a static array. Please don't hesitate to suggest an alternative.
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
2 times, most recently
from
b131f48 to
1546c41
Compare
iyastreb
reviewed
Nov 27, 2025
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
1546c41 to
9408a79
Compare
This patch set minimizes the IO queue abstraction, making it as low- level as possible. It now only wraps the lowest-level IO-related API. It works with a set of IOs (writes or reads) while leaving the Xfer level logic to the upper layer (posix_backend). This patch set allows the posix_backend to implement the common logic, while only offloading the details of specific file access API to the IO queue abstraction. This patch set prepares the code for the POSIX plugin threading model implementation. With it, the threading will be implemented once, in the posix_backend. Signed-off-by: Anton Nayshtut <[email protected]>
anton-nayshtut
force-pushed
the
antonn/posix_file_api
branch
from
9408a79 to
5911caa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This patch set minimizes the IO queue abstraction, making it as low-level as possible.
Why?
This patch set prepares the code for the POSIX plugin threading model implementation. With it, the threading will be implemented once, in the
posix_backend.How?
The IO queue abstraction now only wraps the lowest-level IO-related API. It works with a set of IOs (writes or reads) while leaving the Xfer level logic to the upper layer (
posix_backend).This patch set allows the
posix_backendto implement the common logic, while only offloading the details of specific file access API to the IO queue abstraction.