DEVICE/API: Remove signal_offset param from nixlGpuPostWriteXferReq #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Shalev <[email protected]>
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
Contributor
Author
|
/ok to test 5a6bf09 |
ofirfarjun7
approved these changes
Nov 28, 2025
rakhmets
approved these changes
Dec 1, 2025
Contributor
Author
|
/ok to test 8398219 |
Contributor
Author
|
/build |
brminich
approved these changes
Dec 8, 2025
Contributor
|
/build |
Contributor
Author
|
/build |
Contributor
Author
|
/ok to test f334b28 |
Contributor
Author
|
/ok to test b85310f |
Contributor
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove
signal_offsetparameter fromnixlGpuPostWriteXferReqfunction.Why?
The underlying
ucp_device_put_multifunction does not accept asignal_offsetparameter (unlikeucp_device_put_multi_partial). The parameter was unused and misleading in the API.How?
Removed the parameter from the function signature, documentation, and the call to
ucp_device_put_multi.