Extending plug-in manager #1070
Open
+697
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi alexanderbilk! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
various plug-in types Signed-off-by: Aleksandr Bilkovskii <[email protected]>
alexanderbilk
force-pushed
the
plugin_manager
branch
from
dd9219c to
a9c0b30
Compare
ovidiusm
reviewed
Dec 2, 2025
Contributor
ovidiusm
left a comment
ovidiusm
left a comment
There was a problem hiding this comment.
Thank you for the new version. Overall it looks good to me. I left a few comments, mostly minor.
ColinNV
reviewed
Dec 2, 2025
ColinNV
reviewed
Dec 2, 2025
ColinNV
reviewed
Dec 2, 2025
ColinNV
reviewed
Dec 2, 2025
alexanderbilk
force-pushed
the
plugin_manager
branch
from
f27dc2c to
8c3eddd
Compare
Signed-off-by: Aleksandr Bilkovskii <[email protected]>
alexanderbilk
force-pushed
the
plugin_manager
branch
from
8c3eddd to
2daf58c
Compare
Contributor
|
/build |
ovidiusm
reviewed
Dec 3, 2025
Signed-off-by: Aleksandr Bilkovskii <[email protected]>
alexanderbilk
force-pushed
the
plugin_manager
branch
from
a85667b to
70ce525
Compare
brminich
previously approved these changes
Dec 3, 2025
brminich
reviewed
Dec 3, 2025
Signed-off-by: Aleksandr Bilkovskii <[email protected]>
ovidiusm
previously approved these changes
Dec 3, 2025
Contributor
ovidiusm
left a comment
ovidiusm
left a comment
There was a problem hiding this comment.
approved with minor suggestion
ovidiusm
approved these changes
Dec 3, 2025
Contributor
|
/build |
Contributor
|
/ok to test 7fb0695 |
@brminich, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
brminich
approved these changes
Dec 3, 2025
Contributor
|
/build |
Contributor
|
/ok to test 2e1a6b8 |
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
Contributor
|
/ok to test 2e1a6b8 |
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending plug-in manager infra to support various plug-in types